github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2026-06-09 18:50:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): make removal optional in warn_deprecated (#37056)

Browse Source 
Drop the `NotImplementedError` branch in `warn_deprecated` so callers
can pass `pending=False` without specifying a `removal` version. The
previous behavior contradicted the docstring (which claimed an empty
default would auto-compute a removal version) — no such computation
existed; the function just raised a placeholder "Need to determine which
default deprecation schedule to use" error.
This commit is contained in:
Mason Daugherty
2026-04-28 11:05:31 -04:00
committed by GitHub
parent 5790244b95
commit 37be34be82
2 changed files with 15 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
libs/core/langchain_core/_api/deprecation.py
View File

@@ -136,9 +136,8 @@ def deprecated(
addendum: Additional text appended directly to the final message.
removal: The expected removal version.
With the default (an empty string), a removal version is automatically
computed from since. Set to other Falsy values to not schedule a removal
date.
With the default (an empty string), no removal version is shown in the
warning message.
Cannot be used together with pending.
package: The package of the deprecated object.
@@ -472,21 +471,13 @@ def warn_deprecated(
addendum: Additional text appended directly to the final message.
removal: The expected removal version.
With the default (an empty string), a removal version is automatically
computed from since. Set to other Falsy values to not schedule a removal
date.
With the default (an empty string), no removal version is shown in the
warning message.
Cannot be used together with pending.
package: The package of the deprecated object.
"""
if not pending:
if not removal:
removal = f"in {removal}" if removal else "within ?? minor releases"
msg = (
f"Need to determine which default deprecation schedule to use. "
f"{removal}"
)
raise NotImplementedError(msg)
if not pending and removal:
removal = f"in {removal}"
if not message: