diff --git a/libs/langchain/langchain/document_loaders/mhtml.py b/libs/langchain/langchain/document_loaders/mhtml.py index c7b7f55ec9a..efe1030c243 100644 --- a/libs/langchain/langchain/document_loaders/mhtml.py +++ b/libs/langchain/langchain/document_loaders/mhtml.py @@ -52,7 +52,7 @@ class MHTMLLoader(BaseLoader): message = email.message_from_string(f.read()) parts = message.get_payload() - if type(parts) is not list: + if not isinstance(parts, list): parts = [message] for part in parts: diff --git a/libs/langchain/langchain/retrievers/self_query/myscale.py b/libs/langchain/langchain/retrievers/self_query/myscale.py index 5c11b53d469..e4c5dde4b6c 100644 --- a/libs/langchain/langchain/retrievers/self_query/myscale.py +++ b/libs/langchain/langchain/retrievers/self_query/myscale.py @@ -103,7 +103,7 @@ class MyScaleTranslator(Visitor): value = comparison.value comp = comparison.comparator - value = f"'{value}'" if type(value) is str else value + value = f"'{value}'" if isinstance(value, str) else value # convert timestamp for datetime objects if type(value) is datetime.date: diff --git a/libs/langchain/langchain/utilities/serpapi.py b/libs/langchain/langchain/utilities/serpapi.py index ab132b53afb..4d5af099775 100644 --- a/libs/langchain/langchain/utilities/serpapi.py +++ b/libs/langchain/langchain/utilities/serpapi.py @@ -129,7 +129,7 @@ class SerpAPIWrapper(BaseModel): """Process response from SerpAPI.""" if "error" in res.keys(): raise ValueError(f"Got error from SerpAPI: {res['error']}") - if "answer_box" in res.keys() and type(res["answer_box"]) == list: + if "answer_box" in res.keys() and isinstance(res["answer_box"], list): res["answer_box"] = res["answer_box"][0] if "answer_box" in res.keys() and "answer" in res["answer_box"].keys(): toret = res["answer_box"]["answer"] diff --git a/libs/langchain/tests/integration_tests/document_loaders/test_joplin.py b/libs/langchain/tests/integration_tests/document_loaders/test_joplin.py index 0b7c8dc1952..76a1918b6a1 100644 --- a/libs/langchain/tests/integration_tests/document_loaders/test_joplin.py +++ b/libs/langchain/tests/integration_tests/document_loaders/test_joplin.py @@ -5,7 +5,7 @@ def test_joplin_loader() -> None: loader = JoplinLoader() docs = loader.load() - assert type(docs) is list - assert type(docs[0].page_content) is str - assert type(docs[0].metadata["source"]) is str - assert type(docs[0].metadata["title"]) is str + assert isinstance(docs, list) + assert isinstance(docs[0].page_content, str) + assert isinstance(docs[0].metadata["source"], str) + assert isinstance(docs[0].metadata["title"], str)