From 3c4f32c8b8c8ef6ff35e97d4b5014d4f4d2ea084 Mon Sep 17 00:00:00 2001 From: Aashish Saini <141953346+AashishSainiShorthillsAI@users.noreply.github.com> Date: Tue, 22 Aug 2023 20:04:05 +0530 Subject: [PATCH] Replacing Exception type from ValueError to ImportError (#9588) I have restructured the code to ensure uniform handling of ImportError. In place of previously used ValueError, I've adopted the standard practice of raising ImportError with explanatory messages. This modification enhances code readability and clarifies that any problems stem from module importation. @eyurtsev , @baskaryan Thanks --- libs/langchain/langchain/vectorstores/meilisearch.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/langchain/langchain/vectorstores/meilisearch.py b/libs/langchain/langchain/vectorstores/meilisearch.py index cb9f5d98410..313ae681631 100644 --- a/libs/langchain/langchain/vectorstores/meilisearch.py +++ b/libs/langchain/langchain/vectorstores/meilisearch.py @@ -21,7 +21,7 @@ def _create_client( try: import meilisearch except ImportError: - raise ValueError( + raise ImportError( "Could not import meilisearch python package. " "Please install it with `pip install meilisearch`." )