github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2025-07-19 11:08:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

using getattr and default value to prevent 'OpenSearchVectorSearch' has no attribute 'bulk_size' (#29682)

Browse Source 
- Description: Adding getattr methods and set default value 500 to
cls.bulk_size, it can prevent the error below:
Error: type object 'OpenSearchVectorSearch' has no attribute 'bulk_size'

- Issue: https://github.com/langchain-ai/langchain/issues/29071
This commit is contained in:
manukychen 2025-02-09 03:39:57 +08:00 committed by GitHub
parent 5d581ba22c
commit 3de445d521
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
libs/community/langchain_community/vectorstores/opensearch_vector_search.py
View File

@ -1350,7 +1350,9 @@ class OpenSearchVectorSearch(VectorStore):
""" """
embeddings = embedding.embed_documents(texts) embeddings = embedding.embed_documents(texts)
bulk_size = bulk_size if bulk_size is not None else cls.bulk_size bulk_size = (
bulk_size if bulk_size is not None else getattr(cls, "bulk_size", 500)
)
return cls.from_embeddings( return cls.from_embeddings(
embeddings, embeddings,
texts, texts,
@ -1416,7 +1418,9 @@ class OpenSearchVectorSearch(VectorStore):
""" """
embeddings = await embedding.aembed_documents(texts) embeddings = await embedding.aembed_documents(texts)
bulk_size = bulk_size if bulk_size is not None else cls.bulk_size bulk_size = (
bulk_size if bulk_size is not None else getattr(cls, "bulk_size", 500)
)
return await cls.afrom_embeddings( return await cls.afrom_embeddings(
embeddings, embeddings,
texts, texts,
@ -1503,7 +1507,9 @@ class OpenSearchVectorSearch(VectorStore):
"max_chunk_bytes", "max_chunk_bytes",
"is_aoss", "is_aoss",
] ]
bulk_size = bulk_size if bulk_size is not None else cls.bulk_size bulk_size = (
bulk_size if bulk_size is not None else getattr(cls, "bulk_size", 500)
)
_validate_embeddings_and_bulk_size(len(embeddings), bulk_size) _validate_embeddings_and_bulk_size(len(embeddings), bulk_size)
dim = len(embeddings[0]) dim = len(embeddings[0])
# Get the index name from either from kwargs or ENV Variable # Get the index name from either from kwargs or ENV Variable
@ -1636,7 +1642,9 @@ class OpenSearchVectorSearch(VectorStore):
"max_chunk_bytes", "max_chunk_bytes",
"is_aoss", "is_aoss",
] ]
bulk_size = bulk_size if bulk_size is not None else cls.bulk_size bulk_size = (
bulk_size if bulk_size is not None else getattr(cls, "bulk_size", 500)
)
_validate_embeddings_and_bulk_size(len(embeddings), bulk_size) _validate_embeddings_and_bulk_size(len(embeddings), bulk_size)
dim = len(embeddings[0]) dim = len(embeddings[0])
# Get the index name from either from kwargs or ENV Variable # Get the index name from either from kwargs or ENV Variable