diff --git a/.github/scripts/check_diff.py b/.github/scripts/check_diff.py index 2a7939b6028..fe438e632b4 100644 --- a/.github/scripts/check_diff.py +++ b/.github/scripts/check_diff.py @@ -16,9 +16,11 @@ LANGCHAIN_DIRS = [ "libs/experimental", ] -# for 0.3rc, we are ignoring core dependents -# in order to be able to get CI to pass for individual PRs. -IGNORE_CORE_DEPENDENTS = True +# when set to True, we are ignoring core dependents +# in order to be able to get CI to pass for each individual +# package that depends on core +# e.g. if you touch core, we don't then add textsplitters/etc to CI +IGNORE_CORE_DEPENDENTS = False # ignored partners are removed from dependents # but still run if directly edited @@ -133,7 +135,7 @@ def _get_configs_for_single_dir(job: str, dir_: str) -> List[Dict[str, str]]: def _get_configs_for_multi_dirs( - job: str, dirs_to_run: List[str], dependents: dict + job: str, dirs_to_run: Dict[str, Set[str]], dependents: dict ) -> List[Dict[str, str]]: if job == "lint": dirs = add_dependents( @@ -231,7 +233,6 @@ if __name__ == "__main__": # we now have dirs_by_job # todo: clean this up - map_job_to_configs = { job: _get_configs_for_multi_dirs(job, dirs_to_run, dependents) for job in [ diff --git a/.github/workflows/_lint.yml b/.github/workflows/_lint.yml index 264dfa6eb81..057959d5fcc 100644 --- a/.github/workflows/_lint.yml +++ b/.github/workflows/_lint.yml @@ -7,10 +7,6 @@ on: required: true type: string description: "From which folder this pipeline executes" - langchain-location: - required: false - type: string - description: "Relative path to the langchain library folder" python-version: required: true type: string @@ -63,14 +59,6 @@ jobs: run: | poetry install --with lint,typing - - name: Install langchain editable - working-directory: ${{ inputs.working-directory }} - if: ${{ inputs.langchain-location }} - env: - LANGCHAIN_LOCATION: ${{ inputs.langchain-location }} - run: | - poetry run pip install -e "$LANGCHAIN_LOCATION" - - name: Get .mypy_cache to speed up mypy uses: actions/cache@v4 env: diff --git a/.github/workflows/_test.yml b/.github/workflows/_test.yml index d73ffe65e05..ed37c1ff74b 100644 --- a/.github/workflows/_test.yml +++ b/.github/workflows/_test.yml @@ -7,10 +7,6 @@ on: required: true type: string description: "From which folder this pipeline executes" - langchain-location: - required: false - type: string - description: "Relative path to the langchain library folder" python-version: required: true type: string @@ -41,14 +37,6 @@ jobs: shell: bash run: poetry install --with test - - name: Install langchain editable - working-directory: ${{ inputs.working-directory }} - if: ${{ inputs.langchain-location }} - env: - LANGCHAIN_LOCATION: ${{ inputs.langchain-location }} - run: | - poetry run pip install -e "$LANGCHAIN_LOCATION" - - name: Run core tests shell: bash run: |