github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2026-01-13 11:58:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

core[major]: On Tool End Observation Casting Fix (#18798)

Browse Source 
This PR updates the on_tool_end handlers to return the raw output from the tool instead of casting it to a string. 

This is technically a breaking change, though it's impact is expected to be somewhat minimal. It will fix behavior in `astream_events` as well.

Fixes the following issue #18760 raised by @eyurtsev

---------

Co-authored-by: Eugene Yurtsev <eyurtsev@gmail.com>
This commit is contained in:
Mohammad Mohtashim
2024-03-11 19:59:04 +05:00
committed by GitHub
parent a96a6e0f2c
commit 43db4cd20e
20 changed files with 42 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
libs/core/langchain_core/tools.py
View File

@@ -410,17 +410,13 @@ class ChildTool(BaseTool):
f"Got unexpected type of `handle_tool_error`. Expected bool, str "
f"or callable. Received: {self.handle_tool_error}"
)
run_manager.on_tool_end(
str(observation), color="red", name=self.name, **kwargs
)
run_manager.on_tool_end(observation, color="red", name=self.name, **kwargs)
return observation
except (Exception, KeyboardInterrupt) as e:
run_manager.on_tool_error(e)
raise e
else:
run_manager.on_tool_end(
str(observation), color=color, name=self.name, **kwargs
)
run_manager.on_tool_end(observation, color=color, name=self.name, **kwargs)
return observation
async def arun(
@@ -502,7 +498,7 @@ class ChildTool(BaseTool):
f"or callable. Received: {self.handle_tool_error}"
)
await run_manager.on_tool_end(
str(observation), color="red", name=self.name, **kwargs
observation, color="red", name=self.name, **kwargs
)
return observation
except (Exception, KeyboardInterrupt) as e:
@@ -510,7 +506,7 @@ class ChildTool(BaseTool):
raise e
else:
await run_manager.on_tool_end(
str(observation), color=color, name=self.name, **kwargs
observation, color=color, name=self.name, **kwargs
)
return observation