From 44b33fcc761b77cbfc56c5cb7104e9c18202c4f9 Mon Sep 17 00:00:00 2001 From: aditya thomas Date: Sat, 2 Mar 2024 03:33:45 +0530 Subject: [PATCH] infra: update to pathspec for 'git grep' in lint check (#18178) **Description:** Update to the pathspec for 'git grep' in lint check in the Makefile **Issue:** The pathspec {docs/docs,templates,cookbook} is not handled correctly leading to the error during 'make lint' - "fatal: ambiguous argument '{docs/docs,templates,cookbook}': unknown revision or path not in the working tree." See changes made in https://github.com/langchain-ai/langchain/pull/18058 Co-authored-by: Erick Friis --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 5e66e6c07fb..20271ade0b0 100644 --- a/Makefile +++ b/Makefile @@ -50,7 +50,7 @@ lint lint_package lint_tests: poetry run ruff docs templates cookbook poetry run ruff format docs templates cookbook --diff poetry run ruff --select I docs templates cookbook - git grep 'from langchain import' {docs/docs,templates,cookbook} | grep -vE 'from langchain import (hub)' && exit 1 || exit 0 + git grep 'from langchain import' docs/docs templates cookbook | grep -vE 'from langchain import (hub)' && exit 1 || exit 0 format format_diff: poetry run ruff format docs templates cookbook