github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2025-08-09 13:00:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

community: Fixes use of ImagePromptTemplate with Ollama (#24140)

Browse Source 
Description: ImagePromptTemplate for Multimodal llms like llava when
using Ollama
Twitter handle: https://x.com/a7ulr

Details:

When using llava models / any ollama multimodal llms and passing images
in the prompt as urls, langchain breaks with this error.

```python
image_url_components = image_url.split(",")
                           ^^^^^^^^^^^^^^^^^^^^
AttributeError: 'dict' object has no attribute 'split'
```

From the looks of it, there was bug where the condition did check for a
`url` field in the variable but missed to actually assign it.

This PR fixes ImagePromptTemplate for Multimodal llms like llava when
using Ollama specifically.

@hwchase17
This commit is contained in:
Atul R 2024-07-11 20:31:48 +02:00 committed by GitHub
parent 8327925ab7
commit 457677c1b7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libs/community/langchain_community/chat_models/ollama.py
View File

@ -144,7 +144,7 @@ class ChatOllama(BaseChatModel, _OllamaCommon):
elif ( elif (
isinstance(temp_image_url, dict) and "url" in temp_image_url isinstance(temp_image_url, dict) and "url" in temp_image_url
): ):
image_url = temp_image_url image_url = temp_image_url["url"]
else: else:
raise ValueError( raise ValueError(
"Only string image_url or dict with string 'url' " "Only string image_url or dict with string 'url' "