github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2025-06-25 08:03:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

qdrant: Fix vectors_config access (#24606)

Browse Source 
## Description

Fixes #24558 by accessing `vectors_config` after asserting it to be a
dict.
This commit is contained in:
Anush 2024-07-24 20:24:33 +05:30 committed by GitHub
parent f337f3ed36
commit 4585eaef1b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 17 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
libs/partners/qdrant/langchain_qdrant/qdrant.py
View File

@ -950,21 +950,9 @@ class QdrantVectorStore(VectorStore):
collection_info = client.get_collection(collection_name=collection_name)
vector_config = collection_info.config.params.vectors
if isinstance(vector_config, models.VectorParams) and vector_name != "":
# For single/unnamed vector,
# qdrant-client returns a single VectorParams object
raise QdrantVectorStoreError(
f"Existing Qdrant collection {collection_name} is built "
"with unnamed dense vector. "
f"If you want to reuse it, set `vector_name` to ''(empty string)."
f"If you want to recreate the collection, "
"set `force_recreate` to `True`."
)
else:
if isinstance(vector_config, Dict):
# vector_config is a Dict[str, VectorParams]
if isinstance(vector_config, dict) and vector_name not in vector_config:
if vector_name not in vector_config:
raise QdrantVectorStoreError(
f"Existing Qdrant collection {collection_name} does not "
f"contain dense vector named {vector_name}. "
@ -977,6 +965,20 @@ class QdrantVectorStore(VectorStore):
# Get the VectorParams object for the specified vector_name
vector_config = vector_config[vector_name] # type: ignore
else:
# vector_config is an instance of VectorParams
# Case of a collection with single/unnamed vector.
if vector_name != "":
raise QdrantVectorStoreError(
f"Existing Qdrant collection {collection_name} is built "
"with unnamed dense vector. "
f"If you want to reuse it, set `vector_name` to ''(empty string)."
f"If you want to recreate the collection, "
"set `force_recreate` to `True`."
)
assert vector_config is not None, "VectorParams is None"
if isinstance(dense_embeddings, Embeddings):
vector_size = len(dense_embeddings.embed_documents(["dummy_text"])[0])
elif isinstance(dense_embeddings, list):

2
libs/partners/qdrant/pyproject.toml
View File

@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"
[tool.poetry]
name = "langchain-qdrant"
version = "0.1.2"
version = "0.1.3"
description = "An integration package connecting Qdrant and LangChain"
authors = []
readme = "README.md"