mirror of
https://github.com/hwchase17/langchain.git
synced 2025-08-15 07:36:08 +00:00
community: Passing the model_kwargs
correctly while maintaing backward compatability (#28439)
- **Description:** `Model_Kwargs` was not being passed correctly to `sentence_transformers.SentenceTransformer` which has been corrected while maintaing backward compatability - **Issue:** #28436 --------- Co-authored-by: MoosaTae <sadhis.tae@gmail.com> Co-authored-by: Sadit Wongprayon <101176694+MoosaTae@users.noreply.github.com> Co-authored-by: Erick Friis <erick@langchain.dev>
This commit is contained in:
parent
a3851cb3bc
commit
4c1871d9a8
@ -244,6 +244,11 @@ class HuggingFaceInstructEmbeddings(BaseModel, Embeddings):
|
|||||||
return embedding.tolist()
|
return embedding.tolist()
|
||||||
|
|
||||||
|
|
||||||
|
@deprecated(
|
||||||
|
since="0.2.2",
|
||||||
|
removal="1.0",
|
||||||
|
alternative_import="langchain_huggingface.HuggingFaceEmbeddings",
|
||||||
|
)
|
||||||
class HuggingFaceBgeEmbeddings(BaseModel, Embeddings):
|
class HuggingFaceBgeEmbeddings(BaseModel, Embeddings):
|
||||||
"""HuggingFace sentence_transformers embedding models.
|
"""HuggingFace sentence_transformers embedding models.
|
||||||
|
|
||||||
@ -322,11 +327,25 @@ class HuggingFaceBgeEmbeddings(BaseModel, Embeddings):
|
|||||||
except ImportError as exc:
|
except ImportError as exc:
|
||||||
raise ImportError(
|
raise ImportError(
|
||||||
"Could not import sentence_transformers python package. "
|
"Could not import sentence_transformers python package. "
|
||||||
"Please install it with `pip install sentence_transformers`."
|
"Please install it with `pip install sentence-transformers`."
|
||||||
) from exc
|
) from exc
|
||||||
|
extra_model_kwargs = [
|
||||||
|
"torch_dtype",
|
||||||
|
"attn_implementation",
|
||||||
|
"provider",
|
||||||
|
"file_name",
|
||||||
|
"export",
|
||||||
|
]
|
||||||
|
extra_model_kwargs_dict = {
|
||||||
|
k: self.model_kwargs.pop(k)
|
||||||
|
for k in extra_model_kwargs
|
||||||
|
if k in self.model_kwargs
|
||||||
|
}
|
||||||
self.client = sentence_transformers.SentenceTransformer(
|
self.client = sentence_transformers.SentenceTransformer(
|
||||||
self.model_name, cache_folder=self.cache_folder, **self.model_kwargs
|
self.model_name,
|
||||||
|
cache_folder=self.cache_folder,
|
||||||
|
**self.model_kwargs,
|
||||||
|
model_kwargs=extra_model_kwargs_dict,
|
||||||
)
|
)
|
||||||
|
|
||||||
if "-zh" in self.model_name:
|
if "-zh" in self.model_name:
|
||||||
|
Loading…
Reference in New Issue
Block a user