github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2025-08-13 22:59:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

openai[patch]: Improve error message when response type is malformed (#31619)

Browse Source
This commit is contained in:
Li-Kuang Chen 2025-06-22 02:15:21 +08:00 committed by GitHub
parent 9de4f22205
commit 4ee6112161
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
libs/partners/openai/langchain_openai/chat_models/base.py
View File

@ -1111,15 +1111,27 @@ class BaseChatOpenAI(BaseChatModel):
response_dict = ( response_dict = (
response if isinstance(response, dict) else response.model_dump() response if isinstance(response, dict) else response.model_dump()
) )
# Sometimes the AI Model calling will get error, we should raise it. # Sometimes the AI Model calling will get error, we should raise it (this is
# Otherwise, the next code 'choices.extend(response["choices"])' # typically followed by a null value for `choices`, which we raise for
# will throw a "TypeError: 'NoneType' object is not iterable" error # separately below).
# to mask the true error. Because 'response["choices"]' is None.
if response_dict.get("error"): if response_dict.get("error"):
raise ValueError(response_dict.get("error")) raise ValueError(response_dict.get("error"))
# Raise informative error messages for non-OpenAI chat completions APIs
# that return malformed responses.
try:
choices = response_dict["choices"]
except KeyError as e:
raise KeyError(
f"Response missing `choices` key: {response_dict.keys()}"
) from e
if choices is None:
raise TypeError("Received response with null value for `choices`.")
token_usage = response_dict.get("usage") token_usage = response_dict.get("usage")
for res in response_dict["choices"]:
for res in choices:
message = _convert_dict_to_message(res["message"]) message = _convert_dict_to_message(res["message"])
if token_usage and isinstance(message, AIMessage): if token_usage and isinstance(message, AIMessage):
message.usage_metadata = _create_usage_metadata(token_usage) message.usage_metadata = _create_usage_metadata(token_usage)