github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2025-08-12 06:13:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix type annotation for SQLDatabaseToolkit.llm (#3581)

Browse Source 
Currently `langchain.agents.agent_toolkits.SQLDatabaseToolkit` has a
field `llm` with type `BaseLLM`. This breaks initialization for some
LLMs. For example, trying to use it with GPT4:
```

from langchain.sql_database import SQLDatabase
from langchain.chat_models import ChatOpenAI
from langchain.agents.agent_toolkits import SQLDatabaseToolkit


db = SQLDatabase.from_uri("some_db_uri")
llm = ChatOpenAI(model_name="gpt-4")
toolkit = SQLDatabaseToolkit(db=db, llm=llm)

# pydantic.error_wrappers.ValidationError: 1 validation error for SQLDatabaseToolkit
# llm
#  Can't instantiate abstract class BaseLLM with abstract methods _agenerate, _generate, _llm_type (type=type_error)
```
Seems like much of the rest of the codebase has switched from BaseLLM to
BaseLanguageModel. This PR makes the change for SQLDatabaseToolkit as
well
This commit is contained in:
Aurélien SCHILTZ 2023-04-29 06:19:01 +02:00 committed by GitHub
parent 0a7a2b99b5
commit 502ba6a0be
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
langchain/agents/agent_toolkits/sql/toolkit.py
View File

@ -4,7 +4,7 @@ from typing import List
from pydantic import Field from pydantic import Field
from langchain.agents.agent_toolkits.base import BaseToolkit from langchain.agents.agent_toolkits.base import BaseToolkit
from langchain.llms.base import BaseLLM from langchain.schema import BaseLanguageModel
from langchain.sql_database import SQLDatabase from langchain.sql_database import SQLDatabase
from langchain.tools import BaseTool from langchain.tools import BaseTool
from langchain.tools.sql_database.tool import ( from langchain.tools.sql_database.tool import (
@ -19,7 +19,7 @@ class SQLDatabaseToolkit(BaseToolkit):
"""Toolkit for interacting with SQL databases.""" """Toolkit for interacting with SQL databases."""
db: SQLDatabase = Field(exclude=True) db: SQLDatabase = Field(exclude=True)
llm: BaseLLM = Field(exclude=True) llm: BaseLanguageModel = Field(exclude=True)
@property @property
def dialect(self) -> str: def dialect(self) -> str: