github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2025-08-13 14:50:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

langchain-mongodb: [test-fix] add explicit index_name setting on test vector creation (#19245)

Browse Source 
- **Description:** Tests fail to do value lookup because it does not
specify the index name
  - **Issue:** the issue # Failing integration test
 

- [x] **Add tests and docs**: Tests now pass


- [x] **Lint and test**: Run `make format`, `make lint` and `make test`
from the root of the package(s) you've modified. See contribution
guidelines for more: https://python.langchain.com/docs/contributing/
This commit is contained in:
Jib 2024-03-18 18:52:28 -04:00 committed by GitHub
parent 94e58dd827
commit 516cc44b3f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
libs/partners/mongodb/langchain_mongodb/cache.py
View File

@ -215,6 +215,7 @@ class MongoDBAtlasSemanticCache(BaseCache, MongoDBAtlasVectorSearch):
embedding: Embeddings, embedding: Embeddings,
collection_name: str = "default", collection_name: str = "default",
database_name: str = "default", database_name: str = "default",
index_name: str = "default",
wait_until_ready: bool = False, wait_until_ready: bool = False,
**kwargs: Dict[str, Any], **kwargs: Dict[str, Any],
): ):
@ -229,13 +230,20 @@ class MongoDBAtlasSemanticCache(BaseCache, MongoDBAtlasVectorSearch):
Defaults to "default". Defaults to "default".
database_name (str): MongoDB Database where to store texts. database_name (str): MongoDB Database where to store texts.
Defaults to "default". Defaults to "default".
index_name: Name of the Atlas Search index.
defaults to 'default'
wait_until_ready (bool): Block until MongoDB Atlas finishes indexing wait_until_ready (bool): Block until MongoDB Atlas finishes indexing
the stored text. Hard timeout of 10 seconds. Defaults to False. the stored text. Hard timeout of 10 seconds. Defaults to False.
""" """
client = _generate_mongo_client(connection_string) client = _generate_mongo_client(connection_string)
self.collection = client[database_name][collection_name] self.collection = client[database_name][collection_name]
self._wait_until_ready = wait_until_ready self._wait_until_ready = wait_until_ready
super().__init__(self.collection, embedding, **kwargs) # type: ignore super().__init__(
collection=self.collection,
embedding=embedding,
index_name=index_name,
**kwargs, # type: ignore
)
def lookup(self, prompt: str, llm_string: str) -> Optional[RETURN_VAL_TYPE]: def lookup(self, prompt: str, llm_string: str) -> Optional[RETURN_VAL_TYPE]:
"""Look up based on prompt and llm_string.""" """Look up based on prompt and llm_string."""

1
libs/partners/mongodb/tests/integration_tests/test_cache.py
View File

@ -29,6 +29,7 @@ def llm_cache(cls: Any) -> BaseCache:
connection_string=CONN_STRING, connection_string=CONN_STRING,
collection_name=COLLECTION, collection_name=COLLECTION,
database_name=DATABASE, database_name=DATABASE,
index_name=INDEX_NAME,
wait_until_ready=True, wait_until_ready=True,
) )
) )