From 5271fd76f1922a02a61f6a570c53d7b5a5bc1ab1 Mon Sep 17 00:00:00 2001 From: Bagatur <22008038+baskaryan@users.noreply.github.com> Date: Fri, 20 Jun 2025 14:46:50 -0700 Subject: [PATCH] core[patch]: check before removing tags (#31691) --- libs/core/langchain_core/callbacks/base.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libs/core/langchain_core/callbacks/base.py b/libs/core/langchain_core/callbacks/base.py index 1a792521f07..5b0aa17fe91 100644 --- a/libs/core/langchain_core/callbacks/base.py +++ b/libs/core/langchain_core/callbacks/base.py @@ -1069,8 +1069,10 @@ class BaseCallbackManager(CallbackManagerMixin): tags (list[str]): The tags to remove. """ for tag in tags: - self.tags.remove(tag) - self.inheritable_tags.remove(tag) + if tag in self.tags: + self.tags.remove(tag) + if tag in self.inheritable_tags: + self.inheritable_tags.remove(tag) def add_metadata( self, @@ -1094,8 +1096,8 @@ class BaseCallbackManager(CallbackManagerMixin): keys (list[str]): The keys to remove. """ for key in keys: - self.metadata.pop(key) - self.inheritable_metadata.pop(key) + self.metadata.pop(key, None) + self.inheritable_metadata.pop(key, None) Callbacks = Optional[Union[list[BaseCallbackHandler], BaseCallbackManager]]