mirror of
https://github.com/hwchase17/langchain.git
synced 2025-05-29 19:18:53 +00:00
Fix self query pinecone translation (#3892)
Enum to string conversion handled differently between python 3.9 and 3.11, currently breaking in 3.11 (see #3788). Thanks @peter-brady for catching this!
This commit is contained in:
parent
47a685adcf
commit
52e4fba897
@ -30,7 +30,7 @@ class PineconeTranslator(Visitor):
|
|||||||
f"Received disallowed comparator {func}. Allowed "
|
f"Received disallowed comparator {func}. Allowed "
|
||||||
f"comparators are {self.allowed_comparators}"
|
f"comparators are {self.allowed_comparators}"
|
||||||
)
|
)
|
||||||
return f"${func}"
|
return f"${func.value}"
|
||||||
|
|
||||||
def visit_operation(self, operation: Operation) -> Dict:
|
def visit_operation(self, operation: Operation) -> Dict:
|
||||||
args = [arg.accept(self) for arg in operation.arguments]
|
args = [arg.accept(self) for arg in operation.arguments]
|
||||||
|
0
tests/unit_tests/retrievers/self_query/__init__.py
Normal file
0
tests/unit_tests/retrievers/self_query/__init__.py
Normal file
29
tests/unit_tests/retrievers/self_query/test_pinecone.py
Normal file
29
tests/unit_tests/retrievers/self_query/test_pinecone.py
Normal file
@ -0,0 +1,29 @@
|
|||||||
|
from langchain.chains.query_constructor.ir import (
|
||||||
|
Comparator,
|
||||||
|
Comparison,
|
||||||
|
Operation,
|
||||||
|
Operator,
|
||||||
|
)
|
||||||
|
from langchain.retrievers.self_query.pinecone import PineconeTranslator
|
||||||
|
|
||||||
|
DEFAULT_TRANSLATOR = PineconeTranslator()
|
||||||
|
|
||||||
|
|
||||||
|
def test_visit_comparison() -> None:
|
||||||
|
comp = Comparison(comparator=Comparator.LT, attribute="foo", value=["1", "2"])
|
||||||
|
expected = {"foo": {"$lt": ["1", "2"]}}
|
||||||
|
actual = DEFAULT_TRANSLATOR.visit_comparison(comp)
|
||||||
|
assert expected == actual
|
||||||
|
|
||||||
|
|
||||||
|
def test_visit_operation() -> None:
|
||||||
|
op = Operation(
|
||||||
|
operator=Operator.AND,
|
||||||
|
arguments=[
|
||||||
|
Comparison(comparator=Comparator.LT, attribute="foo", value=2),
|
||||||
|
Comparison(comparator=Comparator.EQ, attribute="bar", value="baz"),
|
||||||
|
],
|
||||||
|
)
|
||||||
|
expected = {"$and": [{"foo": {"$lt": 2}}, {"bar": {"$eq": "baz"}}]}
|
||||||
|
actual = DEFAULT_TRANSLATOR.visit_operation(op)
|
||||||
|
assert expected == actual
|
Loading…
Reference in New Issue
Block a user