From 54a5f83f2eba06b9ef30170a98236723f05df3a0 Mon Sep 17 00:00:00 2001 From: Mason Daugherty Date: Tue, 17 Mar 2026 22:40:30 -0400 Subject: [PATCH] ci(infra): drop redundant opened trigger from issue-link check (#36054) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove `opened` from the `require_issue_link.yml` trigger list. New PRs never have labels at creation time, so the job-level `if` (which requires the `external` label) always evaluated to skip — producing a noisy "Skipped" check on every internal PR. Enforcement chains through `pr_labeler.yml` → `labeled` event, making `opened` a no-op. ## Changes - Drop `opened` from `pull_request_target.types` in `require_issue_link.yml` — only `edited`, `reopened`, and `labeled` remain - Update header comment to document why `opened` is intentionally excluded --- .github/workflows/require_issue_link.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/require_issue_link.yml b/.github/workflows/require_issue_link.yml index e9a88f6f605..fbd770fc69e 100644 --- a/.github/workflows/require_issue_link.yml +++ b/.github/workflows/require_issue_link.yml @@ -16,15 +16,15 @@ # - Deduplicates comments via an HTML marker so re-runs don't spam. # # Dependency: pr_labeler.yml must run first to apply the "external" label -# on new PRs. Both workflows trigger on pull_request_target opened events; -# this workflow additionally listens for the "labeled" event to chain off -# the external classification. +# on new PRs. This workflow chains off that classification via the "labeled" +# event. It does NOT trigger on "opened" because new PRs have no labels yet, +# so the job-level gate would always skip — producing noisy "Skipped" checks. name: Require Issue Link on: pull_request_target: - types: [opened, edited, reopened, labeled] + types: [edited, reopened, labeled] permissions: contents: read