From 59f2c9e737d25b520ee629c0c08f58df32bcb6f3 Mon Sep 17 00:00:00 2001 From: Sydney Runkle <54324534+sydney-runkle@users.noreply.github.com> Date: Tue, 15 Apr 2025 08:49:09 -0400 Subject: [PATCH] Tinkering with CodSpeed (#30824) Fix CI to trigger benchmarks on `run-codspeed-benchmarks` label addition Reduce scope of async benchmark to save time on CI Waiting to merge this PR until we figure out how to use walltime on local runners. --- .github/workflows/codspeed.yml | 5 +++-- libs/core/tests/benchmarks/test_async_callbacks.py | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/codspeed.yml b/.github/workflows/codspeed.yml index e1a23db35fc..fef9889248f 100644 --- a/.github/workflows/codspeed.yml +++ b/.github/workflows/codspeed.yml @@ -14,8 +14,8 @@ on: jobs: codspeed: name: Run benchmarks - if: (github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'run-benchmarks')) - runs-on: codspeed-macro + if: (github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'run-codspeed-benchmarks')) + runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 @@ -41,3 +41,4 @@ jobs: run: | cd libs/core uv run --no-sync pytest ./tests/benchmarks --codspeed + mode: walltime diff --git a/libs/core/tests/benchmarks/test_async_callbacks.py b/libs/core/tests/benchmarks/test_async_callbacks.py index 508934a64b1..5cb58f0210e 100644 --- a/libs/core/tests/benchmarks/test_async_callbacks.py +++ b/libs/core/tests/benchmarks/test_async_callbacks.py @@ -46,7 +46,7 @@ class MyCustomAsyncHandler(AsyncCallbackHandler): @pytest.mark.benchmark async def test_async_callbacks_in_sync(benchmark: BenchmarkFixture) -> None: - infinite_cycle = cycle([AIMessage(content=" ".join(["hello", "goodbye"] * 500))]) + infinite_cycle = cycle([AIMessage(content=" ".join(["hello", "goodbye"] * 5))]) model = GenericFakeChatModel(messages=infinite_cycle) @benchmark # type: ignore[misc]