From 5a956b745fe2ee012ef7456bd7d6490cae8cebc1 Mon Sep 17 00:00:00 2001 From: Mason Daugherty Date: Thu, 22 Jan 2026 17:32:34 -0500 Subject: [PATCH] chore: update commit standards to enforce lowercase titles and required scopes (#34847) --- .github/workflows/pr_lint.yml | 8 +++++++- AGENTS.md | 10 +++++++++- CLAUDE.md | 10 +++++++++- 3 files changed, 25 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pr_lint.yml b/.github/workflows/pr_lint.yml index 6387d69f9f9..4db1507529a 100644 --- a/.github/workflows/pr_lint.yml +++ b/.github/workflows/pr_lint.yml @@ -32,7 +32,13 @@ # fireworks, groq, huggingface, mistralai, nomic, ollama, openai, # perplexity, prompty, qdrant, xai, infra, deps # -# Multiple scopes can be used by separating them with a comma. +# Multiple scopes can be used by separating them with a comma. For example: +# +# feat(core,cli): add multi‐tenant support to core and cli +# +# Note: PRs touching the langchain package should use the 'langchain' scope. It is not +# acceptable to omit the scope for changes to the langchain package, despite it being +# the main package & name of the repo. # # Rules: # 1. The 'Type' must start with a lowercase letter. diff --git a/AGENTS.md b/AGENTS.md index 041044940fa..b123c516e61 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -72,7 +72,15 @@ uv run --group lint mypy . #### Commit standards -Suggest PR titles that follow Conventional Commits format. Refer to .github/workflows/pr_lint for allowed types and scopes. +Suggest PR titles that follow Conventional Commits format. Refer to .github/workflows/pr_lint for allowed types and scopes. Note that all commit/PR titles should be in lowercase with the exception of proper nouns/named entities. All PR titles should include a scope with no exceptions. For example: + +```txt +feat(langchain): add new chat completion feature +fix(core): resolve type hinting issue in vector store +chore(anthropic): update infrastructure dependencies +``` + +Note how `feat(langchain)` includes a scope even though it is the main package and name of the repo. #### Pull request guidelines diff --git a/CLAUDE.md b/CLAUDE.md index 041044940fa..b123c516e61 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -72,7 +72,15 @@ uv run --group lint mypy . #### Commit standards -Suggest PR titles that follow Conventional Commits format. Refer to .github/workflows/pr_lint for allowed types and scopes. +Suggest PR titles that follow Conventional Commits format. Refer to .github/workflows/pr_lint for allowed types and scopes. Note that all commit/PR titles should be in lowercase with the exception of proper nouns/named entities. All PR titles should include a scope with no exceptions. For example: + +```txt +feat(langchain): add new chat completion feature +fix(core): resolve type hinting issue in vector store +chore(anthropic): update infrastructure dependencies +``` + +Note how `feat(langchain)` includes a scope even though it is the main package and name of the repo. #### Pull request guidelines