github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2026-03-18 02:53:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

ci: auto-close external PRs failing issue-link check (#35697)

Browse Source 
Auto-close external PRs that fail the issue-link or assignee check
instead of just failing the CI status. The bot comment now explains the
PR was closed and gives numbered steps to resolve — including asking a
maintainer to reopen, since external contributors can't reopen PRs
themselves.

## Changes
- Close the PR via `pulls.update` after posting the bot comment in the
`check-issue-link` job, gated on `state === 'open'` to avoid redundant
API calls on re-runs
- Rewrite bot comment copy for both failure modes (missing link, not
assigned) to lead with "This PR has been automatically closed" and end
with "ask a maintainer to reopen this PR"
This commit is contained in:
Mason Daugherty
2026-03-09 13:10:23 -04:00
committed by GitHub
parent de5d68c3fb
commit 5b1b37e9f2
1 changed files with 22 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
.github/workflows/require_issue_link.yml vendored
View File

@@ -107,7 +107,7 @@ jobs:
if (error.status !== 404) throw error;
}
- name: Post comment and fail
- name: Post comment, close PR, and fail
if: steps.check-link.outputs.has-link != 'true' || steps.check-link.outputs.is-assigned != 'true'
uses: actions/github-script@v8
with:
@@ -122,21 +122,22 @@ jobs:
if (!hasLink) {
lines = [
marker,
'**This PR is missing a linked issue.** All external contributions must reference an approved issue or discussion.',
'**This PR has been automatically closed** because it does not link to an approved issue.',
'',
'Please add one of the following to your PR description:',
'- `Fixes #<issue_number>`',
'- `Closes #<issue_number>`',
'- `Resolves #<issue_number>`',
'',
'If no issue exists yet, [open one](https://github.com/' + owner + '/' + repo + '/issues/new/choose) and wait for maintainer approval before proceeding.',
'All external contributions must reference an approved issue or discussion. Please:',
'1. Find or [open an issue](https://github.com/' + owner + '/' + repo + '/issues/new/choose) describing the change',
'2. Wait for a maintainer to approve and assign you',
'3. Add `Fixes #<issue_number>`, `Closes #<issue_number>`, or `Resolves #<issue_number>` to your PR description',
'4. Ask a maintainer to reopen this PR',
];
} else {
lines = [
marker,
'**You are not assigned to the linked issue.** External contributors must be assigned to an issue before opening a PR for it.',
'**This PR has been automatically closed** because you are not assigned to the linked issue.',
'',
'Please comment on the issue to request assignment from a maintainer, then update this PR once you have been assigned.',
'External contributors must be assigned to an issue before opening a PR for it. Please:',
'1. Comment on the linked issue to request assignment from a maintainer',
'2. Once assigned, ask a maintainer to reopen this PR',
];
}
@@ -169,6 +170,17 @@ jobs:
console.log('Comment already exists — skipping');
}
// Close the PR
if (context.payload.pull_request.state === 'open') {
await github.rest.pulls.update({
owner,
repo,
pull_number: prNumber,
state: 'closed',
});
console.log(`Closed PR #${prNumber}`);
}
const reason = !hasLink
? 'PR must reference an issue using auto-close keywords (e.g., "Fixes #123").'
: 'PR author must be assigned to the linked issue.';