github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2025-06-23 15:19:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

community: SAP HANA Vector Engine fix for latest HANA release (#23516)

Browse Source 
- **Description:** This PR fixes an issue with SAP HANA Cloud QRC03
version. In that version the number to indicate no length being set for
a vector column changed from -1 to 0. The change in this PR support both
behaviours (old/new).
- **Dependencies:** No dependencies have been introduced.

- **Tests**:  The change is covered by previous unit tests.
This commit is contained in:
yonarw 2024-06-26 15:15:51 +02:00 committed by GitHub
parent 1e3e05b0c3
commit 6d0ebbca1e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libs/community/langchain_community/vectorstores/hanavector.py
View File

@ -125,7 +125,7 @@ class HanaDB(VectorStore):
f'"{self.metadata_column}" NCLOB, ' f'"{self.metadata_column}" NCLOB, '
f'"{self.vector_column}" REAL_VECTOR ' f'"{self.vector_column}" REAL_VECTOR '
) )
if self.vector_column_length == -1: if self.vector_column_length in [-1, 0]:
sql_str += ");" sql_str += ");"
else: else:
sql_str += f"({self.vector_column_length}));" sql_str += f"({self.vector_column_length}));"
@ -186,7 +186,9 @@ class HanaDB(VectorStore):
f"Column {column_name} has the wrong type: {rows[0][0]}" f"Column {column_name} has the wrong type: {rows[0][0]}"
) )
# Check length, if parameter was provided # Check length, if parameter was provided
if column_length is not None: # Length can either be -1 (QRC01+02-24) or 0 (QRC03-24 onwards)
# to indicate no length constraint being present.
if column_length is not None and column_length > 0:
if rows[0][1] != column_length: if rows[0][1] != column_length:
raise AttributeError( raise AttributeError(
f"Column {column_name} has the wrong length: {rows[0][1]}" f"Column {column_name} has the wrong length: {rows[0][1]}"