From 729526ff7c9dd3ff5ca1a223bc4404c3c97a7031 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E0=A4=85=E0=A4=82kur=20=E0=A4=97=E0=A5=8Bswami?= Date: Fri, 30 May 2025 01:29:35 +0530 Subject: [PATCH] huggingface: Undefined model_id fix (#31358) **Description:** This change fixes the undefined model_id issue when instantiating [ChatHuggingFace](https://github.com/langchain-ai/langchain/blob/master/libs/partners/huggingface/langchain_huggingface/chat_models/huggingface.py#L306) **Issue:** Fixes https://github.com/langchain-ai/langchain/issues/31357 @baskaryan @hwchase17 --- .../langchain_huggingface/chat_models/huggingface.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/partners/huggingface/langchain_huggingface/chat_models/huggingface.py b/libs/partners/huggingface/langchain_huggingface/chat_models/huggingface.py index df63c1f3ddb..cceed0e1e5a 100644 --- a/libs/partners/huggingface/langchain_huggingface/chat_models/huggingface.py +++ b/libs/partners/huggingface/langchain_huggingface/chat_models/huggingface.py @@ -775,12 +775,12 @@ class ChatHuggingFace(BaseChatModel): elif _is_huggingface_pipeline(self.llm): from transformers import AutoTokenizer # type: ignore[import] + self.model_id = self.model_id or self.llm.model_id self.tokenizer = ( AutoTokenizer.from_pretrained(self.model_id) if self.tokenizer is None else self.tokenizer ) - self.model_id = self.llm.model_id return elif _is_huggingface_endpoint(self.llm): self.model_id = self.llm.repo_id or self.llm.model