From 7496fe2b167a897ccbc8ec1de029e95f24883bfa Mon Sep 17 00:00:00 2001 From: SteveLiao <32828303+kkk55596@users.noreply.github.com> Date: Wed, 29 May 2024 02:35:38 +0800 Subject: [PATCH] Update parent_document_retriever.py about **kwargs (#22219) Add kwargs in add_documents function **langchain**: Add **kwargs in parent_document_retriever" - **Add kwargs for `add_document` in `parent_document_retriever.py`** If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17. --- .../langchain/retrievers/parent_document_retriever.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libs/langchain/langchain/retrievers/parent_document_retriever.py b/libs/langchain/langchain/retrievers/parent_document_retriever.py index 3c8ac83e7a1..8729b6b391c 100644 --- a/libs/langchain/langchain/retrievers/parent_document_retriever.py +++ b/libs/langchain/langchain/retrievers/parent_document_retriever.py @@ -1,5 +1,5 @@ import uuid -from typing import List, Optional, Sequence +from typing import Any, List, Optional, Sequence from langchain_core.documents import Document from langchain_text_splitters import TextSplitter @@ -74,6 +74,7 @@ class ParentDocumentRetriever(MultiVectorRetriever): documents: List[Document], ids: Optional[List[str]] = None, add_to_docstore: bool = True, + **kwargs: Any, ) -> None: """Adds documents to the docstore and vectorstores. @@ -119,6 +120,6 @@ class ParentDocumentRetriever(MultiVectorRetriever): _doc.metadata[self.id_key] = _id docs.extend(sub_docs) full_docs.append((_id, doc)) - self.vectorstore.add_documents(docs) + self.vectorstore.add_documents(docs, **kwargs) if add_to_docstore: self.docstore.mset(full_docs)