github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2025-06-30 10:23:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Check type of LLM.generate prompts arg (#886)

Browse Source 
Was passing prompt in directly as string and getting nonsense outputs.
Had to inspect source code to realize that first arg should be a list.
Could be nice if there was an explicit error or warning, seems like this
could be a common mistake.
This commit is contained in:
Bagatur 2023-02-04 22:49:17 -08:00 committed by GitHub
parent 32b11101d3
commit 7658263bfb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
langchain/llms/base.py
View File

@ -62,6 +62,13 @@ class BaseLLM(BaseModel, ABC):
self, prompts: List[str], stop: Optional[List[str]] = None self, prompts: List[str], stop: Optional[List[str]] = None
) -> LLMResult: ) -> LLMResult:
"""Run the LLM on the given prompt and input.""" """Run the LLM on the given prompt and input."""
# If string is passed in directly no errors will be raised but outputs will
# not make sense.
if not isinstance(prompts, list):
raise ValueError(
"Argument 'prompts' is expected to be of type List[str], received"
f" argument of type {type(prompts)}."
)
disregard_cache = self.cache is not None and not self.cache disregard_cache = self.cache is not None and not self.cache
if langchain.llm_cache is None or disregard_cache: if langchain.llm_cache is None or disregard_cache:
# This happens when langchain.cache is None, but self.cache is True # This happens when langchain.cache is None, but self.cache is True