From 77eba10f47451cc656ea2655461f2693036dc715 Mon Sep 17 00:00:00 2001 From: Erick Friis Date: Tue, 16 Apr 2024 09:12:36 -0700 Subject: [PATCH] standard-tests: fix default fixtures (#20520) --- .github/scripts/check_diff.py | 4 ++++ .../integration_tests/chat_models.py | 7 +++++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/scripts/check_diff.py b/.github/scripts/check_diff.py index 4fe59b83b05..de1ec42368f 100644 --- a/.github/scripts/check_diff.py +++ b/.github/scripts/check_diff.py @@ -53,6 +53,10 @@ if __name__ == "__main__": dirs_to_run["lint"].add("libs/standard-tests") dirs_to_run["test"].add("libs/partners/mistralai") dirs_to_run["test"].add("libs/partners/openai") + dirs_to_run["test"].add("libs/partners/anthropic") + dirs_to_run["test"].add("libs/partners/ai21") + dirs_to_run["test"].add("libs/partners/fireworks") + dirs_to_run["test"].add("libs/partners/groq") elif file.startswith("libs/cli"): # todo: add cli makefile diff --git a/libs/standard-tests/langchain_standard_tests/integration_tests/chat_models.py b/libs/standard-tests/langchain_standard_tests/integration_tests/chat_models.py index 58646808029..7929dfcba53 100644 --- a/libs/standard-tests/langchain_standard_tests/integration_tests/chat_models.py +++ b/libs/standard-tests/langchain_standard_tests/integration_tests/chat_models.py @@ -33,13 +33,16 @@ class ChatModelIntegrationTests(ABC): def chat_model_has_tool_calling( self, chat_model_class: Type[BaseChatModel] ) -> bool: - return hasattr(chat_model_class, "bind_tools") + return chat_model_class.bind_tools is not BaseChatModel.bind_tools @pytest.fixture def chat_model_has_structured_output( self, chat_model_class: Type[BaseChatModel] ) -> bool: - return hasattr(chat_model_class, "with_structured_output") + return ( + chat_model_class.with_structured_output + is not BaseChatModel.with_structured_output + ) def test_invoke( self, chat_model_class: Type[BaseChatModel], chat_model_params: dict