mirror of
https://github.com/hwchase17/langchain.git
synced 2026-01-30 05:47:54 +00:00
community[patch]: simplify cache logic (#30760)
Thank you for contributing to LangChain!
- [ ] **PR title**: "package: description"
- Where "package" is whichever of langchain, community, core, etc. is
being modified. Use "docs: ..." for purely docs changes, "infra: ..."
for CI changes.
- Example: "community: add foobar LLM"
- [ ] **PR message**: ***Delete this entire checklist*** and replace
with
- **Description:** a description of the change
- **Issue:** the issue # it fixes, if applicable
- **Dependencies:** any dependencies required for this change
- **Twitter handle:** if your PR gets announced, and you'd like a
mention, we'll gladly shout you out!
- [ ] **Add tests and docs**: If you're adding a new integration, please
include
1. a test for the integration, preferably unit tests that do not rely on
network access,
2. an example notebook showing its use. It lives in
`docs/docs/integrations` directory.
- [ ] **Lint and test**: Run `make format`, `make lint` and `make test`
from the root of the package(s) you've modified. See contribution
guidelines for more: https://python.langchain.com/docs/contributing/
Additional guidelines:
- Make sure optional dependencies are imported within a function.
- Please do not add dependencies to pyproject.toml files (even optional
ones) unless they are required for unit tests.
- Most PRs should not touch more than one package.
- Changes should be backwards compatible.
- If you are adding something to community, do not re-import it in
langchain.
If no one reviews your PR within a few days, please @-mention one of
baskaryan, eyurtsev, ccurme, vbarda, hwchase17.
Signed-off-by: zhanluxianshen <zhanluxianshen@163.com>
This commit is contained in:
@@ -1348,17 +1348,14 @@ class CassandraSemanticCache(BaseCache):
|
||||
return await self.embedding.aembed_query(text=text)
|
||||
|
||||
self._aget_embedding = _acache_embedding
|
||||
|
||||
kwargs = {}
|
||||
embedding_dimension: Union[int, Awaitable[int], None] = None
|
||||
if setup_mode == CassandraSetupMode.ASYNC:
|
||||
embedding_dimension = self._aget_embedding_dimension()
|
||||
kwargs["async_setup"] = True
|
||||
elif setup_mode == CassandraSetupMode.SYNC:
|
||||
embedding_dimension = self._get_embedding_dimension()
|
||||
|
||||
kwargs = {}
|
||||
if setup_mode == CassandraSetupMode.ASYNC:
|
||||
kwargs["async_setup"] = True
|
||||
|
||||
self.table = MetadataVectorCassandraTable(
|
||||
session=self.session,
|
||||
keyspace=self.keyspace,
|
||||
|
||||
Reference in New Issue
Block a user