From 80560419b0eeee1330915a2b87f0678e7ab7a320 Mon Sep 17 00:00:00 2001 From: Anush Date: Thu, 6 Jun 2024 23:07:08 +0530 Subject: [PATCH] qdrant[patch]: Make path optional in from_existing_collection() (#21875) ## Description The `path` param is used to specify the local persistence directory, which isn't required if using Qdrant server. This is a breaking but necessary change. --- libs/partners/qdrant/langchain_qdrant/vectorstores.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libs/partners/qdrant/langchain_qdrant/vectorstores.py b/libs/partners/qdrant/langchain_qdrant/vectorstores.py index 7f43885416f..c7e14a06966 100644 --- a/libs/partners/qdrant/langchain_qdrant/vectorstores.py +++ b/libs/partners/qdrant/langchain_qdrant/vectorstores.py @@ -1353,8 +1353,8 @@ class Qdrant(VectorStore): def from_existing_collection( cls: Type[Qdrant], embedding: Embeddings, - path: str, - collection_name: str, + path: Optional[str] = None, + collection_name: Optional[str] = None, location: Optional[str] = None, url: Optional[str] = None, port: Optional[int] = 6333, @@ -1376,6 +1376,10 @@ class Qdrant(VectorStore): This method will return the instance of the store without inserting any new embeddings """ + + if collection_name is None: + raise ValueError("Must specify collection_name. Received None.") + client, async_client = cls._generate_clients( location=location, url=url,