From 81163e3c0c67a3bfc6124ba843383eb258b24764 Mon Sep 17 00:00:00 2001
From: Bagatur <22008038+baskaryan@users.noreply.github.com>
Date: Tue, 22 Aug 2023 11:58:16 -0700
Subject: [PATCH] parent retriever nit (#9570)

if ids are nullable seems like they should have default val None.
mirrors VectorStore interface as well. cc @mcantillon21 @jacoblee93
---
 .../langchain/langchain/retrievers/parent_document_retriever.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libs/langchain/langchain/retrievers/parent_document_retriever.py b/libs/langchain/langchain/retrievers/parent_document_retriever.py
index f56b8929032..6757ba3ddb3 100644
--- a/libs/langchain/langchain/retrievers/parent_document_retriever.py
+++ b/libs/langchain/langchain/retrievers/parent_document_retriever.py
@@ -97,7 +97,7 @@ class ParentDocumentRetriever(BaseRetriever):
     def add_documents(
         self,
         documents: List[Document],
-        ids: Optional[List[str]],
+        ids: Optional[List[str]] = None,
         add_to_docstore: bool = True,
     ) -> None:
         """Adds documents to the docstore and vectorstores.