From 818267bbc349afac522204c4ba62b9e388a0259f Mon Sep 17 00:00:00 2001 From: conjuncts <67614673+conjuncts@users.noreply.github.com> Date: Fri, 23 Aug 2024 09:10:57 -0500 Subject: [PATCH] community: allow chroma DB delete() to use "where" argument (#19826) Thank you for contributing to LangChain! - [x] **PR title**: "package: description" - Where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes. - Example: "community: add foobar LLM" Description: Simply pass kwargs to allow arguments like "where" to be propagated Issue: Previously, db.delete(where={}) wouldn't work for chroma vectorstores Dependencies: N/A Twitter handle: N/A - [x] **Add tests and docs**: If you're adding a new integration, please include 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/docs/integrations` directory. - [x] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ Additional guidelines: - Make sure optional dependencies are imported within a function. - Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests. - Most PRs should not touch more than one package. - Changes should be backwards compatible. - If you are adding something to community, do not re-import it in langchain. If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, hwchase17. --- libs/community/langchain_community/vectorstores/chroma.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/community/langchain_community/vectorstores/chroma.py b/libs/community/langchain_community/vectorstores/chroma.py index fdd756e14df..248dff00d53 100644 --- a/libs/community/langchain_community/vectorstores/chroma.py +++ b/libs/community/langchain_community/vectorstores/chroma.py @@ -894,7 +894,7 @@ class Chroma(VectorStore): Args: ids: List of ids to delete. """ - self._collection.delete(ids=ids) + self._collection.delete(ids=ids, **kwargs) def __len__(self) -> int: """Count the number of documents in the collection."""