From 87fc5ce688d04ebaabe404be788588ebc7e9927d Mon Sep 17 00:00:00 2001 From: Bagatur <22008038+baskaryan@users.noreply.github.com> Date: Thu, 3 Oct 2024 15:00:31 -0700 Subject: [PATCH] core[patch]: exclude model cache from ser (#27086) --- .../langchain_core/language_models/base.py | 2 +- .../language_models/chat_models/test_cache.py | 30 +------------------ .../tests/unit_tests/chat_models/test_base.py | 2 -- 3 files changed, 2 insertions(+), 32 deletions(-) diff --git a/libs/core/langchain_core/language_models/base.py b/libs/core/langchain_core/language_models/base.py index 2df436f780f..93ebe523d89 100644 --- a/libs/core/langchain_core/language_models/base.py +++ b/libs/core/langchain_core/language_models/base.py @@ -98,7 +98,7 @@ class BaseLanguageModel( All language model wrappers inherited from BaseLanguageModel. """ - cache: Union[BaseCache, bool, None] = None + cache: Union[BaseCache, bool, None] = Field(default=None, exclude=True) """Whether to cache the response. * If true, will use the global cache. diff --git a/libs/core/tests/unit_tests/language_models/chat_models/test_cache.py b/libs/core/tests/unit_tests/language_models/chat_models/test_cache.py index 3992420621a..d2455f7a619 100644 --- a/libs/core/tests/unit_tests/language_models/chat_models/test_cache.py +++ b/libs/core/tests/unit_tests/language_models/chat_models/test_cache.py @@ -303,9 +303,7 @@ def test_llm_representation_for_serializable() -> None: chat = CustomChat(cache=cache, messages=iter([])) assert chat._get_llm_string() == ( '{"id": ["tests", "unit_tests", "language_models", "chat_models", ' - '"test_cache", "CustomChat"], "kwargs": {"cache": {"id": ["tests", ' - '"unit_tests", "language_models", "chat_models", "test_cache", ' - '"InMemoryCache"], "lc": 1, "type": "not_implemented"}, "messages": {"id": ' + '"test_cache", "CustomChat"], "kwargs": {"messages": {"id": ' '["builtins", "list_iterator"], "lc": 1, "type": "not_implemented"}}, "lc": ' '1, "name": "CustomChat", "type": "constructor"}---[(\'stop\', None)]' ) @@ -324,20 +322,6 @@ def test_cleanup_serialized() -> None: "CustomChat", ], "kwargs": { - "cache": { - "lc": 1, - "type": "not_implemented", - "id": [ - "tests", - "unit_tests", - "language_models", - "chat_models", - "test_cache", - "InMemoryCache", - ], - "repr": "", - }, "messages": { "lc": 1, "type": "not_implemented", @@ -380,18 +364,6 @@ def test_cleanup_serialized() -> None: "CustomChat", ], "kwargs": { - "cache": { - "id": [ - "tests", - "unit_tests", - "language_models", - "chat_models", - "test_cache", - "InMemoryCache", - ], - "lc": 1, - "type": "not_implemented", - }, "messages": { "id": ["builtins", "list_iterator"], "lc": 1, diff --git a/libs/langchain/tests/unit_tests/chat_models/test_base.py b/libs/langchain/tests/unit_tests/chat_models/test_base.py index b82dead3099..8b7f6445697 100644 --- a/libs/langchain/tests/unit_tests/chat_models/test_base.py +++ b/libs/langchain/tests/unit_tests/chat_models/test_base.py @@ -101,7 +101,6 @@ def test_configurable() -> None: "name": None, "bound": { "name": None, - "cache": None, "disable_streaming": False, "disabled_params": None, "model_name": "gpt-4o", @@ -189,7 +188,6 @@ def test_configurable_with_default() -> None: "name": None, "bound": { "name": None, - "cache": None, "disable_streaming": False, "model": "claude-3-sonnet-20240229", "max_tokens": 1024,