core[patch]: Remove non relevant todos (#26332)

Clean up TODO(0.3)
This commit is contained in:
Eugene Yurtsev
2024-09-11 13:38:39 -04:00
committed by GitHub
parent b9575d586b
commit 8b7f5e1ec0
3 changed files with 0 additions and 8 deletions

View File

@@ -113,10 +113,6 @@ class BaseLanguageModel(
Caching is not currently supported for streaming methods of models.
"""
# Repr = False is consistent with pydantic 1 if verbose = False
# We can relax this for pydantic 2?
# TODO(0.3): Resolve repr for verbose
# Modified just to get unit tests to pass.
verbose: bool = Field(default_factory=_get_verbosity, exclude=True, repr=False)
"""Whether to print out response text."""
callbacks: Callbacks = Field(default=None, exclude=True)

View File

@@ -376,7 +376,6 @@ class RunnableConfigurableFields(DynamicRunnable[Input, Output]):
Returns:
List[ConfigurableFieldSpec]: The configuration specs.
"""
# TODO(0.3): This change removes field_info which isn't needed in pydantic 2
config_specs = []
for field_name, spec in self.fields.items():

View File

@@ -375,9 +375,6 @@ class RunnableWithMessageHistory(RunnableBindingBase):
def get_input_schema(
self, config: Optional[RunnableConfig] = None
) -> Type[BaseModel]:
# TODO(0.3): Verify that this change was correct
# Not enough tests and unclear on why the previous implementation was
# necessary.
from langchain_core.messages import BaseMessage
fields: Dict = {}