github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2025-09-28 15:00:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

core[patch]: Remove non relevant todos (#26332)

Browse Source 
Clean up TODO(0.3)
This commit is contained in:
Eugene Yurtsev
2024-09-11 13:38:39 -04:00
committed by GitHub
parent b9575d586b
commit 8b7f5e1ec0
3 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
libs/core/langchain_core/language_models/base.py
View File

@@ -113,10 +113,6 @@ class BaseLanguageModel(
Caching is not currently supported for streaming methods of models. Caching is not currently supported for streaming methods of models.
""" """
# Repr = False is consistent with pydantic 1 if verbose = False
# We can relax this for pydantic 2?
# TODO(0.3): Resolve repr for verbose
# Modified just to get unit tests to pass.
verbose: bool = Field(default_factory=_get_verbosity, exclude=True, repr=False) verbose: bool = Field(default_factory=_get_verbosity, exclude=True, repr=False)
"""Whether to print out response text.""" """Whether to print out response text."""
callbacks: Callbacks = Field(default=None, exclude=True) callbacks: Callbacks = Field(default=None, exclude=True)

1
libs/core/langchain_core/runnables/configurable.py
View File

@@ -376,7 +376,6 @@ class RunnableConfigurableFields(DynamicRunnable[Input, Output]):
Returns: Returns:
List[ConfigurableFieldSpec]: The configuration specs. List[ConfigurableFieldSpec]: The configuration specs.
""" """
# TODO(0.3): This change removes field_info which isn't needed in pydantic 2
config_specs = [] config_specs = []
for field_name, spec in self.fields.items(): for field_name, spec in self.fields.items():

3
libs/core/langchain_core/runnables/history.py
View File

@@ -375,9 +375,6 @@ class RunnableWithMessageHistory(RunnableBindingBase):
def get_input_schema( def get_input_schema(
self, config: Optional[RunnableConfig] = None self, config: Optional[RunnableConfig] = None
) -> Type[BaseModel]: ) -> Type[BaseModel]:
# TODO(0.3): Verify that this change was correct
# Not enough tests and unclear on why the previous implementation was
# necessary.
from langchain_core.messages import BaseMessage from langchain_core.messages import BaseMessage
fields: Dict = {} fields: Dict = {}