infra: ci failure job (#17989)

.github/workflows/check_diffs.yml

@@ -126,22 +126,23 @@ jobs:
           # grep will exit non-zero if the target message isn't found,
           # and `set -e` above will cause the step to fail.
           echo "$STATUS" | grep 'nothing to commit, working tree clean'
-  ci_end:
+  ci_success:
     name: "CI Success"
     needs: [build, lint, test, compile-integration-tests, dependencies, extended-tests]
-    if: ${{ always() }}
     runs-on: ubuntu-latest
     steps:
       - name: "CI Success"
-        if: ${{ !failure() }}
         run: |
           echo "Success"
           exit 0
+  # this one is just for visibility, where CI success step gets skipped
+  ci_failure:
+    name: "CI Failure"
+    needs: [build, lint, test, compile-integration-tests, dependencies, extended-tests]
+    if: ${{ !success() }}
+    runs-on: ubuntu-latest
+    steps:
       - name: "CI Failure"
-        if: ${{ failure() }}
         run: |
           echo "Failure"
           exit 1
-  
-
-