github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2025-09-01 19:12:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: tests with Dockerfile (#2382)

Browse Source 
Update the Dockerfile to use the `$POETRY_HOME` argument to set the
Poetry home directory instead of adding Poetry to the PATH environment
variable.

Add instructions to the `CONTRIBUTING.md` file on how to run tests with
Docker.

Closes https://github.com/hwchase17/langchain/issues/2324
This commit is contained in:
sergerdn
2023-04-04 13:47:19 +00:00
committed by GitHub
parent fe1eb8ca5f
commit 90973c10b1
3 changed files with 31 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.dockerignore
View File

@@ -1,2 +1,6 @@
.venv .venv
.github .github
.git
.mypy_cache
.pytest_cache
Dockerfile

6
.github/CONTRIBUTING.md vendored
View File

@@ -123,6 +123,12 @@ To run unit tests:
make test make test
``` ```
To run unit tests in Docker:
```bash
make docker_tests
```
If you add new logic, please add a unit test. If you add new logic, please add a unit test.
Integration tests cover logic that requires making calls to outside APIs (often integration with other services). Integration tests cover logic that requires making calls to outside APIs (often integration with other services).

35
Dockerfile
View File

@@ -1,20 +1,23 @@
# This is a Dockerfile for running unit tests
# Use the Python base image # Use the Python base image
FROM python:3.11.2-bullseye AS builder FROM python:3.11.2-bullseye AS builder
# Print Python version # Define the version of Poetry to install (default is 1.4.2)
RUN echo "Python version:" && python --version && echo "" ARG POETRY_VERSION=1.4.2
# Install Poetry # Define the directory to install Poetry to (default is /opt/poetry)
RUN echo "Installing Poetry..." && \ ARG POETRY_HOME=/opt/poetry
curl -sSL https://raw.githubusercontent.com/python-poetry/poetry/master/install-poetry.py | python -
# Add Poetry to PATH # Create a Python virtual environment for Poetry and install it
ENV PATH="${PATH}:/root/.local/bin" RUN python3 -m venv ${POETRY_HOME} && \
$POETRY_HOME/bin/pip install --upgrade pip && \
$POETRY_HOME/bin/pip install poetry==${POETRY_VERSION}
# Test if Poetry is added to PATH # Test if Poetry is installed in the expected path
RUN echo "Poetry version:" && poetry --version && echo "" RUN echo "Poetry version:" && $POETRY_HOME/bin/poetry --version
# Set working directory # Set the working directory for the app
WORKDIR /app WORKDIR /app
# Use a multi-stage build to install dependencies # Use a multi-stage build to install dependencies
@@ -23,8 +26,8 @@ FROM builder AS dependencies
# Copy only the dependency files for installation # Copy only the dependency files for installation
COPY pyproject.toml poetry.lock poetry.toml ./ COPY pyproject.toml poetry.lock poetry.toml ./
# Install Poetry dependencies (this layer will be cached as long as the dependencies don't change) # Install the Poetry dependencies (this layer will be cached as long as the dependencies don't change)
RUN poetry install --no-interaction --no-ansi RUN $POETRY_HOME/bin/poetry install --no-interaction --no-ansi
# Use a multi-stage build to run tests # Use a multi-stage build to run tests
FROM dependencies AS tests FROM dependencies AS tests
@@ -32,8 +35,10 @@ FROM dependencies AS tests
# Copy the rest of the app source code (this layer will be invalidated and rebuilt whenever the source code changes) # Copy the rest of the app source code (this layer will be invalidated and rebuilt whenever the source code changes)
COPY . . COPY . .
# Set entrypoint to run tests RUN /opt/poetry/bin/poetry install --no-interaction --no-ansi
ENTRYPOINT ["poetry", "run", "pytest"]
# Set default command to run all unit tests # Set the entrypoint to run tests using Poetry
ENTRYPOINT ["/opt/poetry/bin/poetry", "run", "pytest"]
# Set the default command to run all unit tests
CMD ["tests/unit_tests"] CMD ["tests/unit_tests"]