github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2025-06-26 08:33:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix broken make targets format_diff and lint_diff (#8344)

Browse Source 
Since the refactoring into sub-projects `libs/langchain` and
`libs/experimental`, the `make` targets `format_diff` and `lint_diff` do
not work anymore when running `make` from these subdirectories. Reason
is that

```
PYTHON_FILES=$(shell git diff --name-only --diff-filter=d master | grep -E '\.py$$|\.ipynb$$')
```

generates paths from the project's root directory instead of the
corresponding subdirectories. This PR fixes this by adding a
`--relative` command line option.

- Tag maintainer: @baskaryan
This commit is contained in:
Martin Krasser 2023-07-27 10:56:55 +02:00 committed by GitHub
parent ae78ef7fe6
commit 93260a9922
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libs/experimental/Makefile
View File

@ -23,7 +23,7 @@ test_watch:
# Define a variable for Python and notebook files. # Define a variable for Python and notebook files.
PYTHON_FILES=. PYTHON_FILES=.
lint format: PYTHON_FILES=. lint format: PYTHON_FILES=.
lint_diff format_diff: PYTHON_FILES=$(shell git diff --name-only --diff-filter=d master | grep -E '\.py$$|\.ipynb$$') lint_diff format_diff: PYTHON_FILES=$(shell git diff --relative=libs/experimental --name-only --diff-filter=d master | grep -E '\.py$$|\.ipynb$$')
lint lint_diff: lint lint_diff:
poetry run mypy $(PYTHON_FILES) poetry run mypy $(PYTHON_FILES)

2
libs/langchain/Makefile
View File

@ -70,7 +70,7 @@ docker_tests:
# Define a variable for Python and notebook files. # Define a variable for Python and notebook files.
PYTHON_FILES=. PYTHON_FILES=.
lint format: PYTHON_FILES=. lint format: PYTHON_FILES=.
lint_diff format_diff: PYTHON_FILES=$(shell git diff --name-only --diff-filter=d master | grep -E '\.py$$|\.ipynb$$') lint_diff format_diff: PYTHON_FILES=$(shell git diff --relative=libs/langchain --name-only --diff-filter=d master | grep -E '\.py$$|\.ipynb$$')
lint lint_diff: lint lint_diff:
poetry run mypy $(PYTHON_FILES) poetry run mypy $(PYTHON_FILES)