From 96278769054c1528b468ec17bb34a06b68796b6a Mon Sep 17 00:00:00 2001 From: Bagatur Date: Wed, 11 Sep 2024 18:23:29 -0700 Subject: [PATCH] nit --- libs/core/langchain_core/load/load.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/libs/core/langchain_core/load/load.py b/libs/core/langchain_core/load/load.py index 5efd947706e..cb13b74cf2a 100644 --- a/libs/core/langchain_core/load/load.py +++ b/libs/core/langchain_core/load/load.py @@ -96,16 +96,15 @@ class Reviver: ): [*namespace, name] = value["id"] + mapping_key = tuple(namespace + [name]) + if namespace[0] not in self.valid_namespaces: raise ValueError(f"Invalid namespace: {value}") - # The root namespace "langchain" is not a valid identifier. - if len(namespace) == 1 and namespace[0] == "langchain": + elif len(namespace) == 1 and namespace[0] == "langchain": raise ValueError(f"Invalid namespace: {value}") - - # If namespace is in mapping, used custom path - mapping_key = tuple(namespace + [name]) - if ( + # Default namespace that has explicit import path + elif ( namespace[0] in DEFAULT_NAMESPACES and mapping_key in ALL_SERIALIZABLE_MAPPINGS ):