From 9b3962fc2521ec0d6ef2ea7c0a40b9c32977671a Mon Sep 17 00:00:00 2001 From: ohbeep <28886507+ohbeep@users.noreply.github.com> Date: Fri, 12 Jan 2024 13:55:35 +0800 Subject: [PATCH] community: Add support of "http" URI for Milvus (#12710) (#15683) - **Description:** Add support of HTTP URI for Milvus - **Issue:** #12710 - **Dependencies:** N/A, --- libs/community/langchain_community/vectorstores/milvus.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libs/community/langchain_community/vectorstores/milvus.py b/libs/community/langchain_community/vectorstores/milvus.py index a1095a2d519..fb7209307af 100644 --- a/libs/community/langchain_community/vectorstores/milvus.py +++ b/libs/community/langchain_community/vectorstores/milvus.py @@ -216,7 +216,13 @@ class Milvus(VectorStore): if host is not None and port is not None: given_address = str(host) + ":" + str(port) elif uri is not None: - given_address = uri.split("https://")[1] + if uri.startswith("https://"): + given_address = uri.split("https://")[1] + elif uri.startswith("http://"): + given_address = uri.split("http://")[1] + else: + logger.error("Invalid Milvus URI: %s", uri) + raise ValueError("Invalid Milvus URI: %s", uri) elif address is not None: given_address = address else: