From 9e4a0e76f6aa9796ad7baa7f623ba98274676c6f Mon Sep 17 00:00:00 2001 From: Eugene Yurtsev Date: Wed, 17 Jul 2024 14:56:48 -0400 Subject: [PATCH] core[patch]: Fix one unit test for chat prompt template (#24362) Minor change that fixes a unit test that had missing assertions. --- libs/core/tests/unit_tests/prompts/test_chat.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libs/core/tests/unit_tests/prompts/test_chat.py b/libs/core/tests/unit_tests/prompts/test_chat.py index 0d57ffd040c..9c01d2a1e80 100644 --- a/libs/core/tests/unit_tests/prompts/test_chat.py +++ b/libs/core/tests/unit_tests/prompts/test_chat.py @@ -794,14 +794,15 @@ def test_chat_input_schema(snapshot: SnapshotAssertion) -> None: prompt_all_required = ChatPromptTemplate.from_messages( messages=[MessagesPlaceholder("history", optional=False), ("user", "${input}")] ) - prompt_all_required.input_variables == {"input"} - prompt_all_required.optional_variables == {"history"} + assert set(prompt_all_required.input_variables) == {"input", "history"} + assert prompt_all_required.optional_variables == [] with pytest.raises(ValidationError): prompt_all_required.input_schema(input="") assert prompt_all_required.input_schema.schema() == snapshot(name="required") prompt_optional = ChatPromptTemplate.from_messages( messages=[MessagesPlaceholder("history", optional=True), ("user", "${input}")] ) - prompt_optional.input_variables == {"history", "input"} + # input variables only lists required variables + assert set(prompt_optional.input_variables) == {"input"} prompt_optional.input_schema(input="") # won't raise error - prompt_optional.input_schema.schema() == snapshot(name="partial") + assert prompt_optional.input_schema.schema() == snapshot(name="partial")