From a4ca1fe0ed82e69f3134886bf27211788ea75760 Mon Sep 17 00:00:00 2001 From: Christophe Bornet Date: Tue, 15 Apr 2025 19:08:40 +0200 Subject: [PATCH] core: Remove some noqa (#30855) --- libs/core/langchain_core/indexing/api.py | 8 ++++++-- libs/core/tests/unit_tests/messages/test_utils.py | 5 +---- .../unit_tests/output_parsers/test_pydantic_parser.py | 1 - 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/libs/core/langchain_core/indexing/api.py b/libs/core/langchain_core/indexing/api.py index 18907182b39..084fe9b8907 100644 --- a/libs/core/langchain_core/indexing/api.py +++ b/libs/core/langchain_core/indexing/api.py @@ -37,14 +37,18 @@ T = TypeVar("T") def _hash_string_to_uuid(input_string: str) -> uuid.UUID: """Hashes a string and returns the corresponding UUID.""" - hash_value = hashlib.sha1(input_string.encode("utf-8")).hexdigest() # noqa: S324 + hash_value = hashlib.sha1( + input_string.encode("utf-8"), usedforsecurity=False + ).hexdigest() return uuid.uuid5(NAMESPACE_UUID, hash_value) def _hash_nested_dict_to_uuid(data: dict[Any, Any]) -> uuid.UUID: """Hashes a nested dictionary and returns the corresponding UUID.""" serialized_data = json.dumps(data, sort_keys=True) - hash_value = hashlib.sha1(serialized_data.encode("utf-8")).hexdigest() # noqa: S324 + hash_value = hashlib.sha1( + serialized_data.encode("utf-8"), usedforsecurity=False + ).hexdigest() return uuid.uuid5(NAMESPACE_UUID, hash_value) diff --git a/libs/core/tests/unit_tests/messages/test_utils.py b/libs/core/tests/unit_tests/messages/test_utils.py index b2bf829acf4..9bc7b35bbfd 100644 --- a/libs/core/tests/unit_tests/messages/test_utils.py +++ b/libs/core/tests/unit_tests/messages/test_utils.py @@ -1,7 +1,6 @@ import base64 import json import re -import typing from collections.abc import Sequence from typing import Any, Callable, Optional, Union @@ -666,9 +665,7 @@ class FakeTokenCountingModel(FakeChatModel): self, messages: list[BaseMessage], tools: Optional[ - Sequence[ - Union[typing.Dict[str, Any], type, Callable, BaseTool] # noqa: UP006 - ] + Sequence[Union[dict[str, Any], type, Callable, BaseTool]] ] = None, ) -> int: return dummy_token_counter(messages) diff --git a/libs/core/tests/unit_tests/output_parsers/test_pydantic_parser.py b/libs/core/tests/unit_tests/output_parsers/test_pydantic_parser.py index c8ee28c4853..9c2d9da3f54 100644 --- a/libs/core/tests/unit_tests/output_parsers/test_pydantic_parser.py +++ b/libs/core/tests/unit_tests/output_parsers/test_pydantic_parser.py @@ -146,7 +146,6 @@ def test_pydantic_output_parser() -> None: ) result = pydantic_parser.parse(DEF_RESULT) - print("parse_result:", result) # noqa: T201 assert result == DEF_EXPECTED_RESULT assert pydantic_parser.OutputType is TestModel