github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2025-07-05 20:58:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: kwargs.pop("redis_url") KeyError: 'redis_url' (#3121)

Browse Source 
This occurred when redis_url was not passed as a parameter even though a
REDIS_URL env variable was present.
This occurred for all methods that eventually called any of:
(from_texts, drop_index, from_existing_index) - i.e. virtually all
methods in the class.
This fixes it
This commit is contained in:
John-David Wuarin 2023-04-20 00:44:39 +01:00 committed by GitHub
parent dbbc340f25
commit a63bfb6c9f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
langchain/vectorstores/redis.py
View File

@ -273,7 +273,8 @@ class Redis(VectorStore):
try: try:
# We need to first remove redis_url from kwargs, # We need to first remove redis_url from kwargs,
# otherwise passing it to Redis will result in an error. # otherwise passing it to Redis will result in an error.
kwargs.pop("redis_url") if "redis_url" in kwargs:
kwargs.pop("redis_url")
client = redis.from_url(url=redis_url, **kwargs) client = redis.from_url(url=redis_url, **kwargs)
# check if redis has redisearch module installed # check if redis has redisearch module installed
_check_redis_module_exist(client, REDIS_REQUIRED_MODULES) _check_redis_module_exist(client, REDIS_REQUIRED_MODULES)
@ -365,7 +366,8 @@ class Redis(VectorStore):
try: try:
# We need to first remove redis_url from kwargs, # We need to first remove redis_url from kwargs,
# otherwise passing it to Redis will result in an error. # otherwise passing it to Redis will result in an error.
kwargs.pop("redis_url") if "redis_url" in kwargs:
kwargs.pop("redis_url")
client = redis.from_url(url=redis_url, **kwargs) client = redis.from_url(url=redis_url, **kwargs)
except ValueError as e: except ValueError as e:
raise ValueError(f"Your redis connected error: {e}") raise ValueError(f"Your redis connected error: {e}")
@ -400,7 +402,8 @@ class Redis(VectorStore):
try: try:
# We need to first remove redis_url from kwargs, # We need to first remove redis_url from kwargs,
# otherwise passing it to Redis will result in an error. # otherwise passing it to Redis will result in an error.
kwargs.pop("redis_url") if "redis_url" in kwargs:
kwargs.pop("redis_url")
client = redis.from_url(url=redis_url, **kwargs) client = redis.from_url(url=redis_url, **kwargs)
# check if redis has redisearch module installed # check if redis has redisearch module installed
_check_redis_module_exist(client, REDIS_REQUIRED_MODULES) _check_redis_module_exist(client, REDIS_REQUIRED_MODULES)