From a7c1bccd6a14343b67ac935177e25cfb158d6dfc Mon Sep 17 00:00:00 2001 From: ccurme Date: Tue, 22 Apr 2025 11:55:33 -0400 Subject: [PATCH] openai[patch]: remove xfails from image token counting tests (#30963) These appear to be passing again. --- .../tests/integration_tests/chat_models/test_base.py | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/libs/partners/openai/tests/integration_tests/chat_models/test_base.py b/libs/partners/openai/tests/integration_tests/chat_models/test_base.py index 369dbd5d2c7..5dc9f82a6de 100644 --- a/libs/partners/openai/tests/integration_tests/chat_models/test_base.py +++ b/libs/partners/openai/tests/integration_tests/chat_models/test_base.py @@ -736,12 +736,6 @@ async def test_openai_response_headers_async(use_responses_api: bool) -> None: assert "content-type" in headers -@pytest.mark.xfail( - reason=( - "As of 12.19.24 OpenAI API returns 1151 instead of 1118. Not clear yet if " - "this is an undocumented API change or a bug on their end." - ) -) def test_image_token_counting_jpeg() -> None: model = ChatOpenAI(model="gpt-4o", temperature=0) image_url = "https://upload.wikimedia.org/wikipedia/commons/thumb/d/dd/Gfp-wisconsin-madison-the-nature-boardwalk.jpg/2560px-Gfp-wisconsin-madison-the-nature-boardwalk.jpg" @@ -774,12 +768,6 @@ def test_image_token_counting_jpeg() -> None: assert expected == actual -@pytest.mark.xfail( - reason=( - "As of 12.19.24 OpenAI API returns 871 instead of 779. Not clear yet if " - "this is an undocumented API change or a bug on their end." - ) -) def test_image_token_counting_png() -> None: model = ChatOpenAI(model="gpt-4o", temperature=0) image_url = "https://upload.wikimedia.org/wikipedia/commons/4/47/PNG_transparency_demonstration_1.png"