github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2025-08-13 14:50:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

openai[patch]: add checking codes for calling AI model get error (#17909)

Browse Source 
**Description:**: adding checking codes for calling AI model get error
in chat_models/base.py and llms/base.py
**Issue**: Sometimes the AI Model calling will get error, we should
raise it.
Otherwise, the next code 'choices.extend(response["choices"])' will
throw a "TypeError: 'NoneType' object is not iterable" error to mask the
true error.
       Because 'response["choices"]' is None.
**Dependencies**: None

---------

Co-authored-by: yangkx <yangkx@asiainfo-int.com>
Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>
This commit is contained in:
Kaixin Yang 2024-03-29 08:17:32 +08:00 committed by GitHub
parent 833d61adb3
commit a8104ea8e9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libs/partners/openai/langchain_openai/chat_models/base.py
View File

@ -522,6 +522,14 @@ class ChatOpenAI(BaseChatModel):
generations = [] generations = []
if not isinstance(response, dict): if not isinstance(response, dict):
response = response.model_dump() response = response.model_dump()
# Sometimes the AI Model calling will get error, we should raise it.
# Otherwise, the next code 'choices.extend(response["choices"])'
# will throw a "TypeError: 'NoneType' object is not iterable" error
# to mask the true error. Because 'response["choices"]' is None.
if response.get("error"):
raise ValueError(response.get("error"))
for res in response["choices"]: for res in response["choices"]:
message = _convert_dict_to_message(res["message"]) message = _convert_dict_to_message(res["message"])
generation_info = dict(finish_reason=res.get("finish_reason")) generation_info = dict(finish_reason=res.get("finish_reason"))

7
libs/partners/openai/langchain_openai/llms/base.py
View File

@ -371,6 +371,13 @@ class BaseOpenAI(BaseLLM):
# dict. For the transition period, we deep convert it to dict. # dict. For the transition period, we deep convert it to dict.
response = response.model_dump() response = response.model_dump()
# Sometimes the AI Model calling will get error, we should raise it.
# Otherwise, the next code 'choices.extend(response["choices"])'
# will throw a "TypeError: 'NoneType' object is not iterable" error
# to mask the true error. Because 'response["choices"]' is None.
if response.get("error"):
raise ValueError(response.get("error"))
choices.extend(response["choices"]) choices.extend(response["choices"])
_update_token_usage(_keys, response, token_usage) _update_token_usage(_keys, response, token_usage)
if not system_fingerprint: if not system_fingerprint: