mirror of
https://github.com/hwchase17/langchain.git
synced 2025-09-12 12:59:07 +00:00
community[patch]: Adding try-except block for GCSDirectoryLoader (#19591)
- **Description:** Implemented try-except block for `GCSDirectoryLoader`. Reason: Users processing large number of unstructured files in a folder may experience many different errors. A try-exception block is added to capture these errors. A new argument `use_try_except=True` is added to enable *silent failure* so that error caused by processing one file does not break the whole function. - **Issue:** N/A - **Dependencies:** no new dependencies - **Twitter handle:** timothywong731 --------- Co-authored-by: Bagatur <baskaryan@gmail.com>
This commit is contained in:
@@ -1,3 +1,4 @@
|
||||
import logging
|
||||
from typing import Callable, List, Optional
|
||||
|
||||
from langchain_core.documents import Document
|
||||
@@ -6,6 +7,8 @@ from langchain_community.document_loaders.base import BaseLoader
|
||||
from langchain_community.document_loaders.gcs_file import GCSFileLoader
|
||||
from langchain_community.utilities.vertexai import get_client_info
|
||||
|
||||
logger = logging.getLogger(__name__)
|
||||
|
||||
|
||||
class GCSDirectoryLoader(BaseLoader):
|
||||
"""Load from GCS directory."""
|
||||
@@ -16,6 +19,7 @@ class GCSDirectoryLoader(BaseLoader):
|
||||
bucket: str,
|
||||
prefix: str = "",
|
||||
loader_func: Optional[Callable[[str], BaseLoader]] = None,
|
||||
continue_on_failure: bool = False,
|
||||
):
|
||||
"""Initialize with bucket and key name.
|
||||
|
||||
@@ -26,11 +30,15 @@ class GCSDirectoryLoader(BaseLoader):
|
||||
loader_func: A loader function that instantiates a loader based on a
|
||||
file_path argument. If nothing is provided, the GCSFileLoader
|
||||
would use its default loader.
|
||||
continue_on_failure: To use try-except block for each file within the GCS
|
||||
directory. If set to `True`, then failure to process a file will not
|
||||
cause an error.
|
||||
"""
|
||||
self.project_name = project_name
|
||||
self.bucket = bucket
|
||||
self.prefix = prefix
|
||||
self._loader_func = loader_func
|
||||
self.continue_on_failure = continue_on_failure
|
||||
|
||||
def load(self) -> List[Document]:
|
||||
"""Load documents."""
|
||||
@@ -55,4 +63,19 @@ class GCSDirectoryLoader(BaseLoader):
|
||||
self.project_name, self.bucket, blob.name, loader_func=self._loader_func
|
||||
)
|
||||
docs.extend(loader.load())
|
||||
# Use the try-except block here
|
||||
try:
|
||||
loader = GCSFileLoader(
|
||||
self.project_name,
|
||||
self.bucket,
|
||||
blob.name,
|
||||
loader_func=self._loader_func,
|
||||
)
|
||||
docs.extend(loader.load())
|
||||
except Exception as e:
|
||||
if self.continue_on_failure:
|
||||
logger.warning(f"Problem processing blob {blob.name}, message: {e}")
|
||||
continue
|
||||
else:
|
||||
raise e
|
||||
return docs
|
||||
|
Reference in New Issue
Block a user