github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2025-08-01 17:13:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

partners: add 'model' alias for consistency in embedding classes (#28374)

Browse Source 
**Description:** This PR introduces a `model` alias for the embedding
classes that contain the attribute `model_name`, to ensure consistency
across the codebase, as suggested by a moderator in a previous PR. The
change aligns the usage of attribute names across the project (see for
example
[here](65deeddd5d/libs/partners/groq/langchain_groq/chat_models.py (L304))).
**Issue:** This PR addresses the suggestion from the review of issue
#28269.
**Dependencies:**  None

---------

Co-authored-by: Eugene Yurtsev <eyurtsev@gmail.com>
Co-authored-by: Erick Friis <erick@langchain.dev>
This commit is contained in:
Manuel 2024-12-13 17:30:00 -05:00 committed by GitHub
parent 3107d78517
commit af2e0a7ede
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libs/partners/huggingface/langchain_huggingface/embeddings/huggingface.py
View File

@ -26,7 +26,7 @@ class HuggingFaceEmbeddings(BaseModel, Embeddings):
) )
""" """
model_name: str = DEFAULT_MODEL_NAME model_name: str = Field(default=DEFAULT_MODEL_NAME, alias="model")
"""Model name to use.""" """Model name to use."""
cache_folder: Optional[str] = None cache_folder: Optional[str] = None
"""Path to store models. """Path to store models.
@ -68,6 +68,7 @@ class HuggingFaceEmbeddings(BaseModel, Embeddings):
model_config = ConfigDict( model_config = ConfigDict(
extra="forbid", extra="forbid",
protected_namespaces=(), protected_namespaces=(),
populate_by_name=True,
) )
def _embed( def _embed(