From b1644bc9add6947e2b99f94f300abf1986044772 Mon Sep 17 00:00:00 2001 From: Bagatur Date: Thu, 31 Aug 2023 00:43:34 -0700 Subject: [PATCH] cr --- .../integrations/vectorstores/tencentvectordb.ipynb | 4 ++-- libs/langchain/langchain/vectorstores/tencentvectordb.py | 6 +++--- .../vectorstores/test_tencentvectordb.py | 8 -------- 3 files changed, 5 insertions(+), 13 deletions(-) diff --git a/docs/extras/integrations/vectorstores/tencentvectordb.ipynb b/docs/extras/integrations/vectorstores/tencentvectordb.ipynb index 35fc17d4ceb..fb9bf232e35 100644 --- a/docs/extras/integrations/vectorstores/tencentvectordb.ipynb +++ b/docs/extras/integrations/vectorstores/tencentvectordb.ipynb @@ -89,7 +89,7 @@ "metadata": {}, "outputs": [], "source": [ - "vector_db = TencentVectorDB(embedding_function=embeddings, connection_params=conn_params)\n", + "vector_db = TencentVectorDB(embeddings, conn_params)\n", "\n", "vector_db.add_texts([\"Ankush went to Princeton\"])\n", "query = \"Where did Ankush go to college?\"\n", @@ -114,7 +114,7 @@ "name": "python", "nbconvert_exporter": "python", "pygments_lexer": "ipython3", - "version": "3.9.17" + "version": "3.9.1" } }, "nbformat": 4, diff --git a/libs/langchain/langchain/vectorstores/tencentvectordb.py b/libs/langchain/langchain/vectorstores/tencentvectordb.py index 75541f85e67..a4660c564c2 100644 --- a/libs/langchain/langchain/vectorstores/tencentvectordb.py +++ b/libs/langchain/langchain/vectorstores/tencentvectordb.py @@ -78,7 +78,7 @@ class TencentVectorDB(VectorStore): def __init__( self, - embedding_function: Embeddings, + embedding: Embeddings, connection_params: ConnectionParams, index_params: IndexParams = IndexParams(128), database_name: str = "LangChainDatabase", @@ -87,7 +87,7 @@ class TencentVectorDB(VectorStore): ): self.document = guard_import("tcvectordb.model.document") tcvectordb = guard_import("tcvectordb") - self.embedding_func = embedding_function + self.embedding_func = embedding self.index_params = index_params self.vdb_client = tcvectordb.VectorDBClient( url=connection_params.url, @@ -193,7 +193,7 @@ class TencentVectorDB(VectorStore): else: index_params.dimension = dimension vector_db = cls( - embedding_function=embedding, + embedding=embedding, connection_params=connection_params, index_params=index_params, database_name=database_name, diff --git a/libs/langchain/tests/integration_tests/vectorstores/test_tencentvectordb.py b/libs/langchain/tests/integration_tests/vectorstores/test_tencentvectordb.py index 3cf2758763c..53970997c17 100644 --- a/libs/langchain/tests/integration_tests/vectorstores/test_tencentvectordb.py +++ b/libs/langchain/tests/integration_tests/vectorstores/test_tencentvectordb.py @@ -83,11 +83,3 @@ def test_tencent_vector_db_no_drop() -> None: time.sleep(3) output = docsearch.similarity_search("foo", k=10) assert len(output) == 6 - - -# if __name__ == "__main__": -# test_tencent_vector_db() -# test_tencent_vector_db_with_score() -# test_tencent_vector_db_max_marginal_relevance_search() -# test_tencent_vector_db_add_extra() -# test_tencent_vector_db_no_drop()