From b1f649bca5f35e84bfb64d70760428286a37a4bf Mon Sep 17 00:00:00 2001 From: Nikhil Suresh Date: Sat, 26 Aug 2023 00:10:52 +0000 Subject: [PATCH] fixed issue with white space and added unit tests --- libs/langchain/langchain/chains/qa_with_sources/base.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libs/langchain/langchain/chains/qa_with_sources/base.py b/libs/langchain/langchain/chains/qa_with_sources/base.py index 2c75e60e36c..c7d0b76ab51 100644 --- a/libs/langchain/langchain/chains/qa_with_sources/base.py +++ b/libs/langchain/langchain/chains/qa_with_sources/base.py @@ -121,10 +121,8 @@ class BaseQAWithSourcesChain(Chain, ABC): def _split_sources(self, answer: str) -> Tuple[str, str]: """Split sources from answer.""" if re.search(r"SOURCES?[:\s]", answer, re.IGNORECASE): - answer, sources = re.split( - r"SOURCES?[:\s]|QUESTION:\s", answer, flags=re.IGNORECASE - )[:2] - sources = re.split(r"\n", sources)[0] + answer, sources = re.split(r"SOURCES?[:\s]|QUESTION:\s", answer, flags=re.IGNORECASE)[:2] + sources = re.split(r"\n", sources)[0].strip() else: sources = "" return answer, sources