github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2025-08-07 12:06:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

chroma[patch]: Update logic for assigning ids

Browse Source
This commit is contained in:
Kaiwei Zhang 2024-12-13 16:58:34 -05:00 committed by GitHub
parent 9c55c75eb5
commit b909d54e70
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
libs/partners/chroma/langchain_chroma/vectorstores.py
View File

@ -433,6 +433,8 @@ class Chroma(VectorStore):
# Populate IDs # Populate IDs
if ids is None: if ids is None:
ids = [str(uuid.uuid4()) for _ in uris] ids = [str(uuid.uuid4()) for _ in uris]
else:
ids = [id if id is not None else str(uuid.uuid4()) for id in ids]
embeddings = None embeddings = None
# Set embeddings # Set embeddings
if self._embedding_function is not None and hasattr( if self._embedding_function is not None and hasattr(
@ -519,10 +521,8 @@ class Chroma(VectorStore):
if ids is None: if ids is None:
ids = [str(uuid.uuid4()) for _ in texts] ids = [str(uuid.uuid4()) for _ in texts]
else: else:
# Assign strings to any null IDs ids = [id if id is not None else str(uuid.uuid4()) for id in ids]
for idx, _id in enumerate(ids):
if _id is None:
ids[idx] = str(uuid.uuid4())
embeddings = None embeddings = None
texts = list(texts) texts = list(texts)
if self._embedding_function is not None: if self._embedding_function is not None:
@ -1169,6 +1169,8 @@ class Chroma(VectorStore):
) )
if ids is None: if ids is None:
ids = [str(uuid.uuid4()) for _ in texts] ids = [str(uuid.uuid4()) for _ in texts]
else:
ids = [id if id is not None else str(uuid.uuid4()) for id in ids]
if hasattr( if hasattr(
chroma_collection._client, "get_max_batch_size" chroma_collection._client, "get_max_batch_size"
) or hasattr( # for Chroma 0.5.1 and above ) or hasattr( # for Chroma 0.5.1 and above

0
libs/partners/chroma/tests/integration_tests/test_standard.py → libs/partners/chroma/tests/unit_tests/test_standard.py
View File