From bc21045ee054b233aa6c4f65653b26a0a7ff340f Mon Sep 17 00:00:00 2001 From: bahtyar <34988899+Bahtya@users.noreply.github.com> Date: Tue, 7 Apr 2026 09:53:16 +0800 Subject: [PATCH] fix(ollama): prevent `_convert_messages_to_ollama_messages` from mutating caller list (#36567) Fixes #36564 The method modifies messages[idx] in-place when converting v1 format content. Add messages = list(messages) to create a shallow copy before any mutations. 1 line change in libs/partners/ollama/langchain_ollama/chat_models.py Co-authored-by: bahtya Co-authored-by: Mason Daugherty --- libs/partners/ollama/langchain_ollama/chat_models.py | 1 + 1 file changed, 1 insertion(+) diff --git a/libs/partners/ollama/langchain_ollama/chat_models.py b/libs/partners/ollama/langchain_ollama/chat_models.py index ffe8766b802..4892e350f26 100644 --- a/libs/partners/ollama/langchain_ollama/chat_models.py +++ b/libs/partners/ollama/langchain_ollama/chat_models.py @@ -865,6 +865,7 @@ class ChatOllama(BaseChatModel): Returns: List of messages in Ollama format. """ + messages = list(messages) # shallow copy to avoid mutating caller's list for idx, message in enumerate(messages): # Handle message content written in v1 format if (