From bee470cc29fec53216891f71e47217ee4eec3694 Mon Sep 17 00:00:00 2001 From: Mason Daugherty Date: Wed, 10 Jun 2026 00:22:42 -0400 Subject: [PATCH] ci(infra): attach release artifacts from package dist directory (#38010) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The release workflow's `mark-release` job downloads built wheels to `/dist/` but told `ncipollo/release-action` to glob `dist/*`. Because JS actions don't honor `defaults.run.working-directory`, that pattern resolved against the repo root, matched nothing, and logged `Artifact pattern :dist/* did not match any files`. The warning is non-fatal, so tags and releases were still created — just with no assets attached. Verified across published releases (`langchain-groq`, `langchain-core`, `langchain-openai`, `langchain-anthropic`): every one has an empty asset list. --- .github/workflows/_release.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/_release.yml b/.github/workflows/_release.yml index d54a1cf7e23..205706748ba 100644 --- a/.github/workflows/_release.yml +++ b/.github/workflows/_release.yml @@ -723,7 +723,11 @@ jobs: - name: Create Tag uses: ncipollo/release-action@339a81892b84b4eeb0f6e744e4574d79d0d9b8dd # v1 with: - artifacts: "dist/*" + # JS actions ignore `defaults.run.working-directory`, so this glob is + # resolved from the repo root. Point it at the package's `dist/` + # (where `download-artifact` placed the wheels) instead of a bare + # `dist/*`, which never matched and attached no assets to releases. + artifacts: "${{ env.EFFECTIVE_WORKING_DIR }}/dist/*" token: ${{ secrets.GITHUB_TOKEN }} generateReleaseNotes: false tag: ${{needs.build.outputs.pkg-name}}==${{ needs.build.outputs.version }}