From c08bf05e28fda6ea3ce0fd315b7ba8a83c2dedeb Mon Sep 17 00:00:00 2001 From: Will Fu-Hinthorn Date: Thu, 2 Apr 2026 22:58:08 +0000 Subject: [PATCH] fix(core): lint fixes for tracer metadata tests Co-Authored-By: Claude Opus 4.6 --- .../runnables/test_tracing_interops.py | 17 ++++------------- .../tests/unit_tests/tracers/test_langchain.py | 6 ++---- 2 files changed, 6 insertions(+), 17 deletions(-) diff --git a/libs/core/tests/unit_tests/runnables/test_tracing_interops.py b/libs/core/tests/unit_tests/runnables/test_tracing_interops.py index 86344b653a5..9a67678656d 100644 --- a/libs/core/tests/unit_tests/runnables/test_tracing_interops.py +++ b/libs/core/tests/unit_tests/runnables/test_tracing_interops.py @@ -4,7 +4,6 @@ import json import sys import uuid from inspect import isasyncgenfunction -from collections.abc import Mapping from typing import TYPE_CHECKING, Any, Literal from unittest.mock import MagicMock, patch @@ -18,9 +17,7 @@ from langchain_core.runnables.base import RunnableLambda, RunnableParallel from langchain_core.tracers.langchain import LangChainTracer if TYPE_CHECKING: - from collections.abc import AsyncGenerator, Callable, Coroutine, Generator - - from langchain_core.callbacks import BaseCallbackHandler + from collections.abc import AsyncGenerator, Callable, Coroutine, Generator, Mapping def _get_posts(client: Client) -> list[dict[str, Any]]: @@ -598,12 +595,8 @@ class TestTracerMetadataThroughInvoke: # Both parent and child should have config metadata (inherited) # and tracer metadata (patched in) for name, md in name_to_md.items(): - assert md.get("config_key") == "config_val", ( - f"{name} missing config_key" - ) - assert md.get("tracer_key") == "tracer_val", ( - f"{name} missing tracer_key" - ) + assert md.get("config_key") == "config_val", f"{name} missing config_key" + assert md.get("tracer_key") == "tracer_val", f"{name} missing tracer_key" def test_tracer_metadata_not_leaked_to_sibling_handlers(self) -> None: """Tracer metadata does not leak to other callback handlers. @@ -621,9 +614,7 @@ class TestTracerMetadataThroughInvoke: class MetadataCapture(BaseCallbackHandler): """Callback handler that records metadata from chain events.""" - def on_chain_start( - self, *args: Any, **kwargs: Any - ) -> None: + def on_chain_start(self, *_args: Any, **kwargs: Any) -> None: received_metadata.append(dict(kwargs.get("metadata", {}))) capture = MetadataCapture() diff --git a/libs/core/tests/unit_tests/tracers/test_langchain.py b/libs/core/tests/unit_tests/tracers/test_langchain.py index 2ff50d58899..1f70bd60cf0 100644 --- a/libs/core/tests/unit_tests/tracers/test_langchain.py +++ b/libs/core/tests/unit_tests/tracers/test_langchain.py @@ -714,15 +714,13 @@ class TestPatchMissingMetadata: def _make_run( metadata: dict[str, Any] | None = None, ) -> Run: - run_id = uuid.uuid4() - run = Run( - id=run_id, + return Run( + id=uuid.uuid4(), name="test", inputs={}, run_type="chain", extra={"metadata": metadata or {}}, ) - return run def test_adds_metadata_when_run_has_none(self) -> None: """Tracer metadata fills in when the run has no matching keys."""