github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2025-06-05 14:43:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix AddableDict raising exception when used with non-addable values (#12785)

Browse Source 
<!-- Thank you for contributing to LangChain!

Replace this entire comment with:
  - **Description:** a description of the change, 
  - **Issue:** the issue # it fixes (if applicable),
  - **Dependencies:** any dependencies required for this change,
- **Tag maintainer:** for a quicker response, tag the relevant
maintainer (see below),
- **Twitter handle:** we announce bigger features on Twitter. If your PR
gets announced, and you'd like a mention, we'll gladly shout you out!

Please make sure your PR is passing linting and testing before
submitting. Run `make format`, `make lint` and `make test` to check this
locally.

See contribution guidelines for more information on how to write/run
tests, lint, etc:

https://github.com/langchain-ai/langchain/blob/master/.github/CONTRIBUTING.md

If you're adding a new integration, please include:
1. a test for the integration, preferably unit tests that do not rely on
network access,
2. an example notebook showing its use. It lives in `docs/extras`
directory.

If no one reviews your PR within a few days, please @-mention one of
@baskaryan, @eyurtsev, @hwchase17.
 -->
This commit is contained in:
Nuno Campos 2023-11-02 18:56:29 +00:00 committed by GitHub
parent 49e283a0cd
commit c4fdf78d03
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libs/langchain/langchain/schema/runnable/utils.py
View File

@ -192,7 +192,11 @@ class AddableDict(Dict[str, Any]):
if key not in chunk or chunk[key] is None: if key not in chunk or chunk[key] is None:
chunk[key] = other[key] chunk[key] = other[key]
elif other[key] is not None: elif other[key] is not None:
chunk[key] = chunk[key] + other[key] try:
added = chunk[key] + other[key]
except TypeError:
added = other[key]
chunk[key] = added
return chunk return chunk
def __radd__(self, other: AddableDict) -> AddableDict: def __radd__(self, other: AddableDict) -> AddableDict:
@ -201,7 +205,11 @@ class AddableDict(Dict[str, Any]):
if key not in chunk or chunk[key] is None: if key not in chunk or chunk[key] is None:
chunk[key] = self[key] chunk[key] = self[key]
elif self[key] is not None: elif self[key] is not None:
chunk[key] = chunk[key] + self[key] try:
added = chunk[key] + self[key]
except TypeError:
added = self[key]
chunk[key] = added
return chunk return chunk